Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-4929: Removed reference to non-existent ObjectStateService example #218

Merged
merged 1 commit into from
Mar 29, 2023
Merged

IBX-4929: Removed reference to non-existent ObjectStateService example #218

merged 1 commit into from
Mar 29, 2023

Conversation

adriendupuis
Copy link
Contributor

@adriendupuis adriendupuis commented Mar 15, 2023 •
edited
Loading

Question Answer
JIRA issue IBX-4929
Type bug
Target Ibexa version v4.4.1
BC breaks no

The @example leads to a non existing path.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@sonarcloud
Copy link

sonarcloud bot commented Mar 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@adriendupuis adriendupuis marked this pull request as ready for review March 16, 2023 09:34
@alongosz alongosz changed the title IBX-4929: ObjectStateService PhpDoc: rm non existant example IBX-4929: Removed reference to non-existent ObjectStateService example Mar 29, 2023
@alongosz alongosz merged commit 1c57c05 into main Mar 29, 2023
@alongosz alongosz deleted the adriendupuis-patch-2 branch March 29, 2023 10:57
@alongosz
Copy link
Member

Thank you @adriendupuis 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@alongosz alongosz alongosz approved these changes

Assignees

@adamwojs adamwojs

@mikadamczyk mikadamczyk

@Steveb-p Steveb-p

@alongosz alongosz

@ciastektk ciastektk

Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@adriendupuis @alongosz @mikadamczyk @adamwojs @Steveb-p @ciastektk