Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-6254: Refactored MemoryCachingHandler to use CacheIdentifierGeneratorInterface with shortened persistence cache tags #252

Merged
merged 2 commits into from
Aug 10, 2023
Merged

IBX-6254: Refactored MemoryCachingHandler to use CacheIdentifierGeneratorInterface with shortened persistence cache tags #252

merged 2 commits into from
Aug 10, 2023

Conversation

konradoboza
Copy link
Contributor

@konradoboza konradoboza commented Jul 31, 2023 •
edited
Loading

Question Answer
JIRA issue IBX-6254
Type improvement
Target Ibexa version v4.5
BC breaks no

I recently stumbled upon lack of persistence cache generation within MemoryCachingHandler. I refactored the code to rely on CacheIdentifierGeneratorInterface using shortened patterns.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@konradoboza konradoboza self-assigned this Jul 31, 2023
@konradoboza konradoboza force-pushed the ibx-6254-old-persistence-cache-format branch from 7e9e885 to 9dd2bb8 Compare August 1, 2023 11:05
@konradoboza konradoboza requested review from alongosz and a team August 1, 2023 12:10
@alongosz alongosz requested a review from a team August 1, 2023 12:46
@konradoboza konradoboza requested a review from a team August 1, 2023 12:54
@konradoboza konradoboza force-pushed the ibx-6254-old-persistence-cache-format branch from 9dd2bb8 to dee53f2 Compare August 8, 2023 06:44
@konradoboza
IBX-6254: Refactored MemoryCachingHandler to use `CacheIdentifierGe…
a372556 
…neratorInterface` with shortened persistence cache tags
@konradoboza
adjusted new loadContentTypesByFieldDefinitionIdentifier method to …
e38e8bd 
…properly generate its cache key identifier
@konradoboza konradoboza force-pushed the ibx-6254-old-persistence-cache-format branch from dee53f2 to e38e8bd Compare August 8, 2023 11:36
@sonarcloud
Copy link

sonarcloud bot commented Aug 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@micszo micszo self-assigned this Aug 10, 2023
micszo
micszo approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on Ibexa Commerce 4.5.2-dev.

@micszo micszo removed their assignment Aug 10, 2023
@alongosz alongosz merged commit aab07d6 into 4.5 Aug 10, 2023
24 checks passed
@alongosz alongosz deleted the ibx-6254-old-persistence-cache-format branch August 10, 2023 09:56
@micszo micszo mentioned this pull request Aug 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alongosz alongosz alongosz approved these changes

@micszo micszo micszo approved these changes

@ViniTou ViniTou ViniTou approved these changes

Assignees

@kisztof kisztof

@mikadamczyk mikadamczyk

@alongosz alongosz

Labels
Improvement QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@konradoboza @alongosz @micszo @ViniTou @kisztof @mikadamczyk