Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused property from Image Storage #262

Merged
merged 3 commits into from
Aug 21, 2023
Merged

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Aug 20, 2023

Question Answer
JIRA issue -
Type improvement
Target Ibexa version v4.5
BC breaks no

\Ibexa\Core\FieldType\Image\ImageStorage::$deprecationWarner is reported as unused by static code analysis.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@sonarcloud
Copy link

sonarcloud bot commented Aug 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@adamwojs adamwojs requested a review from a team August 21, 2023 07:35
@konradoboza konradoboza requested a review from a team August 21, 2023 07:37
@Steveb-p
Copy link
Contributor

Strange, I thought we had PHPStan already enabled in core, and I don't see a baseline change here 🤔

@konradoboza
Copy link
Contributor

konradoboza commented Aug 21, 2023

Strange, I thought we had PHPStan already enabled in core, and I don't see a baseline change here 🤔

Had the same thought, but isn't that related to the low PHPStan level which is the case for core?

@Steveb-p
Copy link
Contributor

Strange, I thought we had PHPStan already enabled in core, and I don't see a baseline change here 🤔

Had the same thought, but isn't that related to the low PHPStan level which is the case for core?

If so, then we should increase it as soon as possible.

@adamwojs adamwojs merged commit 35cbf06 into 4.5 Aug 21, 2023
27 checks passed
@adamwojs adamwojs deleted the removed_unused_property branch August 21, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants