IBX-6315: Added LocationArgumentResolver #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciastektk
changed the title
ciastektk
force-pushed
the
added-location-argument-resolver
branch
from
81272b3
to
d0df5b2
Compare
adamwojs
approved these changes
Sep 2, 2023
konradoboza
approved these changes
Sep 4, 2023
alongosz
approved these changes
Sep 4, 2023
There was a problem hiding this comment.
@ciastektk is there a JIRA issue connected with this change?
webhdx
approved these changes
Sep 4, 2023
ciastektk
changed the title
2 tasks
ciastektk
force-pushed
the
added-location-argument-resolver
branch
from
8db4946
to
9c53b7f
Compare
Nattfarinn
reviewed
Sep 4, 2023
tests/bundle/Core/ControllerArgumentResolver/LocationArgumentResolverTest.php
Outdated
Show resolved
Hide resolved
kisztof
approved these changes
Sep 6, 2023
konradoboza
approved these changes
Sep 6, 2023
ciastektk
force-pushed
the
added-location-argument-resolver
branch
from
e091b4d
to
f932081
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
alongosz
approved these changes
Sep 6, 2023
ciastektk
force-pushed
the
added-location-argument-resolver
branch
from
f932081
to
8a315d5
Compare
micszo
approved these changes
Oct 19, 2023
Co-authored-by: Adam Wójs <adam@wojs.pl>
Co-authored-by: Andrew Longosz <alongosz@users.noreply.github.com>
ciastektk
force-pushed
the
added-location-argument-resolver
branch
from
8a315d5
to
25ace1c
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4.6This PR adds ArgumentResolver for locationId passed as query parameter. Already added LocationParamConverter works only for locationId passed as route attribute.
Checklist:
$ composer fix-cs).@ibexa/engineering).