Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-5705: Fixed InteractiveLoginToken using PostAuthenticationGuardToken #274

Merged
merged 9 commits into from
Sep 19, 2023
Merged

IBX-5705: Fixed InteractiveLoginToken using PostAuthenticationGuardToken #274

merged 9 commits into from
Sep 19, 2023

Conversation

Nattfarinn
Copy link
Contributor

@Nattfarinn Nattfarinn commented Sep 15, 2023 •
edited
Loading

Question Answer
JIRA issue IBX-5705
Type bug
Target Ibexa version v4.6
BC breaks no

InteractiveLoginToken wrapping PostAuthenticationGuardToken has to be authenticated by default, otherwise it leads to unexpected Symfony behaviour.

Fixes issue in OAuth2 Server: https://github.com/ibexa/oauth2-server/pull/21

Symfony ref. https://github.com/symfony/security-guard/blob/5.4/Token/PostAuthenticationGuardToken.php#L50-L51

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@Nattfarinn Nattfarinn requested review from alongosz and a team September 15, 2023 07:53
@alongosz alongosz requested a review from a team September 15, 2023 08:21
konradoboza
konradoboza approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@konradoboza konradoboza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from failing code style.

@konradoboza konradoboza requested a review from a team September 15, 2023 10:51
@konradoboza konradoboza self-requested a review September 18, 2023 06:50
@Nattfarinn @Steveb-p
Update src/lib/MVC/Symfony/Security/InteractiveLoginToken.php
8d8b4a4 
Co-authored-by: Paweł Niedzielski <pawel.niedzielski@ibexa.co>
@alongosz alongosz requested a review from a team September 18, 2023 07:55
@sonarcloud
Copy link

sonarcloud bot commented Sep 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

mnocon
mnocon approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested together with https://github.com/ibexa/oauth2-server/pull/21/files , looks good!

@alongosz alongosz merged commit 90c5d66 into main Sep 19, 2023
22 checks passed
@alongosz alongosz deleted the fix-interactive-login-token branch September 19, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradoboza konradoboza konradoboza approved these changes

@kisztof kisztof kisztof approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@alongosz alongosz alongosz approved these changes

@mnocon mnocon mnocon approved these changes

Assignees

@kisztof kisztof

@mikadamczyk mikadamczyk

@alongosz alongosz

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Nattfarinn @kisztof @Steveb-p @alongosz @mnocon @konradoboza @mikadamczyk