Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-6937: Changed expected min and max value types to numeric instead of int #308

Merged
merged 3 commits into from
Jan 5, 2024
Merged

IBX-6937: Changed expected min and max value types to numeric instead of int #308

merged 3 commits into from
Jan 5, 2024

Conversation

ciastektk
Copy link
Contributor

@ciastektk ciastektk commented Dec 12, 2023 •
edited
Loading

Question Answer
JIRA issue IBX-6937
Type improvement
Target Ibexa version v4.6
BC breaks no

Ref: 1044c97

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@ciastektk ciastektk force-pushed the ibx-6937-adjusted-file-size-criterion branch from 00e507d to 92f51bf Compare December 12, 2023 11:18
@ciastektk ciastektk force-pushed the ibx-6937-adjusted-file-size-criterion branch 3 times, most recently from 453e226 to 8ec5e47 Compare December 12, 2023 11:36
@ciastektk ciastektk requested a review from a team December 12, 2023 12:28
@konradoboza konradoboza requested a review from a team December 12, 2023 14:55
@Nattfarinn Nattfarinn requested a review from a team December 12, 2023 14:58
@micszo micszo self-assigned this Jan 3, 2024
@micszo micszo mentioned this pull request Jan 3, 2024
Closed
@webhdx webhdx force-pushed the ibx-6937-adjusted-file-size-criterion branch from 8ec5e47 to b9cfcca Compare January 3, 2024 15:02
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

micszo
micszo approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested sanities for floats in image file size on Postgres and MariaDB.

Migrations in database reinstall OK.

Did not find issues.

@micszo micszo removed their assignment Jan 5, 2024
@webhdx webhdx merged commit fb6e450 into main Jan 5, 2024
21 checks passed
@webhdx webhdx deleted the ibx-6937-adjusted-file-size-criterion branch January 5, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kisztof kisztof kisztof approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@Nattfarinn Nattfarinn Nattfarinn approved these changes

@webhdx webhdx webhdx approved these changes

@micszo micszo micszo approved these changes

@konradoboza konradoboza konradoboza approved these changes

Assignees

@kisztof kisztof

@mikadamczyk mikadamczyk

@alongosz alongosz

Labels
Improvement QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@ciastektk @kisztof @Steveb-p @Nattfarinn @webhdx @micszo @konradoboza @mikadamczyk @alongosz