Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specified return type for PermissionResolver #328

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Specified return type for PermissionResolver #328

merged 1 commit into from
Feb 5, 2024

Conversation

Steveb-p
Copy link
Contributor

@Steveb-p Steveb-p commented Feb 5, 2024

Question Answer
JIRA issue N/A
Type improvement
Target Ibexa version v4.6

This PR adds specific return type information to PermissionResolver::hasAccess() method.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Steveb-p Steveb-p requested a review from a team February 5, 2024 09:15
@ciastektk ciastektk requested a review from a team February 5, 2024 09:25
@Steveb-p Steveb-p merged commit 12b3b45 into main Feb 5, 2024
21 checks passed
@Steveb-p Steveb-p deleted the permission-resolver-phpdoc branch February 5, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@ciastektk ciastektk ciastektk approved these changes

@webhdx webhdx webhdx approved these changes

Assignees

@mikadamczyk mikadamczyk

@alongosz alongosz

Labels
Improvement Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Steveb-p @adamwojs @ciastektk @webhdx @mikadamczyk @alongosz