Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7769 Added safety check to ibexa:install command when tables in database exists #336

Merged
merged 3 commits into from
Mar 7, 2024
Merged

IBX-7769 Added safety check to ibexa:install command when tables in database exists #336

merged 3 commits into from
Mar 7, 2024

Conversation

papcio122
Copy link
Contributor

@papcio122 papcio122 commented Feb 16, 2024 •
edited
Loading

Question Answer
JIRA issue IBX-7769
Type improvement
Target Ibexa version v4.5
BC breaks yes/no

Added safety check to ibexa:install command when tables in database exists

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@papcio122 papcio122 changed the base branch from main to 4.5 February 16, 2024 09:14
@papcio122 papcio122 force-pushed the IBX-7769-add-sfety-check-to-install-command branch from ec8d40d to d204c93 Compare February 16, 2024 09:26
@alongosz alongosz requested a review from a team February 16, 2024 10:45
@alongosz alongosz requested a review from a team February 21, 2024 12:49
@konradoboza konradoboza requested a review from a team February 21, 2024 12:51
@papcio122 @mnocon
Update src/bundle/RepositoryInstaller/Command/InstallPlatformCommand.php
fb34987 
Co-authored-by: Marek Nocoń <mnocon@users.noreply.github.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@micszo micszo self-assigned this Mar 6, 2024
micszo
micszo approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on Ibexa Commerce 4.5.6-dev.

@micszo micszo removed their assignment Mar 7, 2024
@alongosz alongosz merged commit a321523 into 4.5 Mar 7, 2024
21 checks passed
@alongosz alongosz deleted the IBX-7769-add-sfety-check-to-install-command branch March 7, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnocon mnocon mnocon left review comments

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@alongosz alongosz alongosz approved these changes

@micszo micszo micszo approved these changes

@konradoboza konradoboza konradoboza approved these changes

Assignees

@mikadamczyk mikadamczyk

@alongosz alongosz

Labels
Improvement QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@papcio122 @mikadamczyk @alongosz @mnocon @micszo @konradoboza