Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-8032: Added proper casting to int for width/height in image search field #354

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

konradoboza
Copy link
Contributor

@konradoboza konradoboza commented Apr 12, 2024

🎫 Issue IBX-8032

Description:

This PR is about adding integer casting for width/height values to work with SearchField::getOrientation() method. It seems some legacy data might fail as strict typing is introduced here. However, the old way of composing index like

new Search\Field(
    'width',
    $width,
    new Search\FieldType\IntegerField()
),

is less forgiving and accepts some "wider spectrum" of types.

For QA:

Since there is no easy way to reproduce the issue I think sanities will do in this case.

Documentation:

Copy link

sonarcloud bot commented Apr 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@konradoboza konradoboza added Bug Something isn't working Ready for review labels Apr 12, 2024
@konradoboza konradoboza requested review from ciastektk and a team April 12, 2024 10:11
@alongosz alongosz requested a review from a team April 12, 2024 10:15
@alongosz alongosz merged commit 045cb9e into 4.6 Apr 22, 2024
23 checks passed
@alongosz alongosz deleted the ibx-8032-added-search-field-orientation-casting branch April 22, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working QA approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants