Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed DebugTemplate missing newly introduced return type in display method #355

Closed
wants to merge 1 commit into from
Closed

Fixed DebugTemplate missing newly introduced return type in display method #355

wants to merge 1 commit into from

Conversation

Steveb-p
Copy link
Contributor

🎫 Issue N/A

Twig 3.9.x introduced return type to an internal class, which we extend. As a current issue resolution I have added return types where applicable.

@Steveb-p Steveb-p requested review from alongosz and a team April 17, 2024 12:56
@Steveb-p Steveb-p added Bug Something isn't working Ready for review labels Apr 17, 2024
@Steveb-p Steveb-p changed the base branch from main to 4.6 April 17, 2024 12:56
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@konradoboza konradoboza requested a review from a team April 17, 2024 12:58
@alongosz alongosz mentioned this pull request Apr 17, 2024
Merged
@alongosz
Copy link
Member

Backport: ezsystems/ezplatform-kernel#406

@alongosz alongosz marked this pull request as draft April 17, 2024 14:15
@alongosz
Copy link
Member

Merged via 6403884.

@alongosz alongosz closed this Apr 18, 2024
@alongosz alongosz deleted the fix-debug-template branch April 18, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tischsoic tischsoic tischsoic approved these changes

@konradoboza konradoboza konradoboza approved these changes

@alongosz alongosz Awaiting requested review from alongosz

Assignees

@mikadamczyk mikadamczyk

@alongosz alongosz

@tischsoic tischsoic

Labels
Bug Something isn't working Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Steveb-p @alongosz @tischsoic @konradoboza @mikadamczyk