Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge branch '1.3' of ezsystems/ezplatform-kernel into 4.6 #356

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Merge branch '1.3' of ezsystems/ezplatform-kernel into 4.6 #356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81464c6
Fixed missing return types for DebugTemplate class
alongosz Apr 17, 2024
6403884
Merged branch '1.3' of ezsystems/ezplatform-kernel into 4.6
alongosz Apr 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4155,11 +4155,6 @@ parameters:
count: 1
path: src/bundle/Debug/IbexaDebugBundle.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Debug\\\\Twig\\\\DebugTemplate\\:\\:display\\(\\) has no return type specified\\.$#"
count: 1
path: src/bundle/Debug/Twig/DebugTemplate.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Debug\\\\Twig\\\\DebugTemplate\\:\\:display\\(\\) has parameter \\$blocks with no value type specified in iterable type array\\.$#"
count: 1
Expand All @@ -4170,11 +4165,6 @@ parameters:
count: 1
path: src/bundle/Debug/Twig/DebugTemplate.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Debug\\\\Twig\\\\DebugTemplate\\:\\:doDisplay\\(\\) has no return type specified\\.$#"
count: 1
path: src/bundle/Debug/Twig/DebugTemplate.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Debug\\\\Twig\\\\DebugTemplate\\:\\:doDisplay\\(\\) has parameter \\$blocks with no value type specified in iterable type array\\.$#"
count: 1
Expand All @@ -4185,16 +4175,6 @@ parameters:
count: 1
path: src/bundle/Debug/Twig/DebugTemplate.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Debug\\\\Twig\\\\DebugTemplate\\:\\:getDebugInfo\\(\\) return type has no value type specified in iterable type array\\.$#"
count: 1
path: src/bundle/Debug/Twig/DebugTemplate.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Debug\\\\Twig\\\\DebugTemplate\\:\\:getSourceContext\\(\\) should return Twig\\\\Source but returns string\\.$#"
count: 1
path: src/bundle/Debug/Twig/DebugTemplate.php

-
message: "#^Parameter \\#1 \\$haystack of function stripos expects string, string\\|false\\|null given\\.$#"
count: 1
Expand Down
24 changes: 8 additions & 16 deletions src/bundle/Debug/Twig/DebugTemplate.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
namespace Ibexa\Bundle\Debug\Twig;

use Symfony\Component\Filesystem\Filesystem;
use Twig\Source;
use Twig\Template;

/**
Expand All @@ -19,7 +20,7 @@ class DebugTemplate extends Template
{
private $fileSystem;

public function display(array $context, array $blocks = [])
public function display(array $context, array $blocks = []): void
{
$this->fileSystem = $this->fileSystem ?: new Filesystem();

Expand Down Expand Up @@ -65,34 +66,25 @@ public function display(array $context, array $blocks = [])
}
}

/**
* {@inheritdoc}
*/
public function getTemplateName()
public function getTemplateName(): string
{
return '';
}

/**
* {@inheritdoc}
*/
public function getSourceContext()
public function getSourceContext(): Source
{
return '';
return new Source('', '');
}

/**
* {@inheritdoc}
*/
protected function doDisplay(array $context, array $blocks = [])
protected function doDisplay(array $context, array $blocks = []): string
{
return '';
}

/**
* {@inheritdoc}
* @return array<mixed>
*/
public function getDebugInfo()
public function getDebugInfo(): array
{
return [];
}
Expand Down
Loading