Dropped obsolete Debug Bundle DebugTemplate class #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alongosz
force-pushed
the
drop-debug-template
branch
from
29c9caf
to
9506ddc
Compare
alongosz
force-pushed
the
drop-debug-template
branch
from
9506ddc
to
fd21844
Compare
|
Steveb-p
approved these changes
Apr 18, 2024
webhdx
approved these changes
Apr 18, 2024
konradoboza
approved these changes
Apr 18, 2024
tischsoic
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
base_template_classconfiguration option has been removed in Twig 3.0.0-BETA1 so currently while Twig Bundle doesn't show deprecation, it's basically unused. Given that we've extended an internal class there, which was not correct, we've decided to drop the class completely.The deprecation warning for
base_template_classTwig Bundle config has been proposed by @Steveb-p via symfony/symfony#54657.BC consideration
[1] This is an internal class that was never documented as consumable or extendable. The feature which it provided is not available anymore in Twig, making the class obsolete. Because of all the above this is not a BC break.
For QA:
Regression tests are enough, since there's no evidence of this class being in use at all anywhere. Running them just in case.
Documentation:
Not needed as we've dropped an internal class.