IBX-8012: UrlAliasGenerator should load location with provided languages
#361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
konradoboza
approved these changes
Apr 25, 2024
webhdx
approved these changes
Apr 25, 2024
alongosz
deleted the
ibx-8012-UrlAliasGenerator-loadLocation-with-languages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When a location is loaded for
reverseLookupand one is in default site access that cannot load such location because of languages configuration andalwaysAvailableflag turned off for this location's content it would result in an exception. If one is providinglanguagesparameter for URL to be generated these languages should be utilized when loading such a location to avoid mentioned exceptions as one should be able to generate URL for a different site access in which such a location can be loaded properly.