IBX-8452: Fixed string substitution for Plural Value Object when casting to string #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`\Ibexa\Contracts\Core\Repository\Values\Translation\Plural` had an incorrect casting to string implementation which resulted in the effect opposite to the desired one
|
adamwojs
approved these changes
Jun 27, 2024
konradoboza
approved these changes
Jun 28, 2024
mikadamczyk
approved these changes
Jun 28, 2024
Steveb-p
approved these changes
Jun 28, 2024
|
Regressions passed. No QA needed after all. Merged per @adamwojs request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
This is a back-port of #360 to v4.6.
When an instance of Plural value object was cast to string, it produced results opposite to the expected. For plural result it used singular message and for singular result - a plural one.
For QA:
See steps to reproduce in the JIRA issue.Regression run: ibexa/commerce#897
Documentation:
No doc needed.