IBX-4000: Changed the method name creation for logCall in callable function

[mateuszdebinski]

🎫 Issue	IBX-4000

Related PRs:

• https://github.com/ibexa/fieldtype-page/pull/136

Description:

The problem is that the Ibexa\Bundle\Debug\Collector\PersistenceCacheCollector::getCalls function expects us to format the method as Namespace::Function. With callable functions, METHOD returns Namespace{closure} instead of the correct value. To prevent this, we must use CLASS in these functions and add the method name manually, which will allow us to correctly save the call function to log.

For QA:

Documentation:

[alongosz]

@mateuszdebinski could you please describe what was the issue here, so everyone can understand what was changed and why?

Also, what could be done so such easy to miss mistake won't happen in any future implementations?

[mateuszdebinski]

@alongosz The problem is that the Ibexa\Bundle\Debug\Collector\PersistenceCacheCollector::getCalls function expects us to format the method as Namespace::Function. With callable functions, __METHOD__ returns Namespace\{closure} instead of the correct value. To prevent this, we must use __CLASS__ in these functions and add the method name manually, which will allow us to correctly save the call function to log.

[alongosz]

@alongosz The problem is that the Ibexa\Bundle\Debug\Collector\PersistenceCacheCollector::getCalls function expects us to format the method as Namespace::Function. With callable functions, __METHOD__ returns Namespace\{closure} instead of the correct value. To prevent this, we must use __CLASS__ in these functions and add the method name manually, which will allow us to correctly save the call function to log.

This is something which should land in the PR description ;-)

That doesn't answer however section question - what can be done to ensure all implementations reference a correct method?

[Steveb-p]

Why is the handler acquisition moved?

[mateuszdebinski]

We currently use this variable in the test
->with(get_class($handler) . '::' . $method, self::isType('array'));

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud