Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-2301: Added configuration to enable translations from i18n package #78

Merged
merged 2 commits into from
Feb 18, 2022

Conversation

mikadamczyk
Copy link
Contributor

@mikadamczyk mikadamczyk commented Feb 14, 2022

Question Answer
JIRA issue IBX-2301
Type feature
Target Ibexa version v4.0
BC breaks no

Because i18n package will be added to the product there is a need to enable available translations on demand. This will prevent a bad user experience because of the lack of translations in the product. By default when a package with translations is installed, a language of a user interface is taken from browser settings, if a user doesn't choose his language under user settings. That is why a new setting is introduced.
To see translated strings in a product such configuration should be added.

ibexa:
    ui:
        translations:
            enabled: true

PR which adds new package to oss ibexa/oss#39

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@mikadamczyk mikadamczyk self-assigned this Feb 14, 2022
@adamwojs adamwojs changed the title IBX-2301: Added onfiguration to enable translations from i18n package IBX-2301: Added configuration to enable translations from i18n package Feb 14, 2022
@mikadamczyk mikadamczyk added the Doc needed The changes require some documentation label Feb 16, 2022
@tomaszszopinski tomaszszopinski self-assigned this Feb 17, 2022
Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP 4.0.x-dev. CI error is unrelated to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants