Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-6071: Handled custom attributes deselection #104

Merged
merged 14 commits into from
Jul 21, 2023
Merged

IBX-6071: Handled custom attributes deselection #104

merged 14 commits into from
Jul 21, 2023

Conversation

barw4
Copy link
Contributor

@barw4 barw4 commented Jul 11, 2023

Question Answer
JIRA issue IBX-6071
Improvement yes
New feature no
Target version v4.5
BC breaks no
Tests pass yes
Doc needed no

Basically, the title says it all.

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@barw4 barw4 requested a review from a team July 11, 2023 13:16
@barw4 barw4 self-assigned this Jul 11, 2023
@barw4 barw4 requested review from Gengar-i and a team July 11, 2023 13:48
@barw4 barw4 requested review from a team and Gengar-i July 11, 2023 13:53
@barw4 barw4 requested a review from a team July 11, 2023 15:11
@barw4 barw4 requested a review from dew326 July 12, 2023 09:47
@barw4 barw4 requested a review from lucasOsti July 12, 2023 09:54
@barw4 barw4 requested a review from dew326 July 12, 2023 11:05
@dew326 dew326 requested a review from GrabowskiM July 12, 2023 11:11
@micszo micszo self-assigned this Jul 20, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
10.5% 10.5% Duplication

micszo
micszo approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on Ibexa Experience 4.5.2-dev.

@micszo micszo removed their assignment Jul 21, 2023
@konradoboza konradoboza merged commit 824548e into 4.5 Jul 21, 2023
22 checks passed
@konradoboza konradoboza deleted the ibx-6071-custom-attributes-deselection branch July 21, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@dew326 dew326 dew326 approved these changes

@micszo micszo micszo approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@Gengar-i Gengar-i Gengar-i approved these changes

Assignees

@alongosz alongosz

@dew326 dew326

@barw4 barw4

Labels
Improvement QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@barw4 @GrabowskiM @dew326 @micszo @lucasOsti @Gengar-i @alongosz @konradoboza