IBX-6077: Custom classes and attributes on table in ReichText Online Editor are not saved

[vidarl]

Question	Answer
JIRA issue	IBX-6077
Bug/Improvement	yes
New feature	no
Target version	4.5
BC breaks	no
Tests pass	yes
Doc needed	no

EDIT : I have made a new PR where the whole problem is solved in XSLT. I think that is a better alternative : #107

The editor used in 4.x saves tables inside a <figure> element. The editor would then save class and data-ezattribute on the <figure> element, instead of in the <table>.
We did apparently not fix our converters accordingly for 4.x.

I have solved it by making a php converter that simply copies the class and data-ezattribute attributes from <figure> to <table> element. It could have been done in XSLT too, but AFAIK we could not have reused templates like ezattribute. Instead it would be cut&paste from that template but fetching attributes from ancestor instead of current node.

I have not done anything with docbook->xhtml5.edit transformation. It seems like editor is backward compatible and also deals fine with having missing <figure> element and the attributes stored on <table> element as before..

TODO:

• Implement feature / fix a bug.
• Implement tests.
• Fix new code according to Coding Standards ($ composer fix-cs).
• Ask for Code Review.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

No Coverage information
0.0% Duplication

[vidarl]

#107 is the way to go, so closing this one