Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-5932: Added max-height for .ck.ck-dropdown__panel #112

Merged
merged 1 commit into from
Aug 1, 2023
Merged

IBX-5932: Added max-height for .ck.ck-dropdown__panel #112

merged 1 commit into from
Aug 1, 2023

Conversation

mateuszdebinski
Copy link
Contributor

Question Answer
JIRA issue IBX-5932
Bug/Improvement yes
New feature no
Target version v4.5
BC breaks no
Tests pass yes
Doc needed no

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@mateuszdebinski mateuszdebinski requested a review from a team July 20, 2023 21:08
@mateuszdebinski mateuszdebinski changed the base branch from main to 4.5 July 20, 2023 21:09
@mateuszdebinski mateuszdebinski self-assigned this Jul 20, 2023
@mateuszdebinski mateuszdebinski added Bug Something isn't working Ready for review labels Jul 20, 2023
@mateuszdebinski
Copy link
Contributor Author

regarding the bug in the tests, the problem has been fixed here: #111

mnocon
mnocon approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved!

@mateuszdebinski mateuszdebinski force-pushed the IBX-5932_Image_Variation_Selection_cut_off branch from ded4a7b to 3250e38 Compare August 1, 2023 10:53
@sonarcloud
Copy link

sonarcloud bot commented Aug 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alongosz alongosz merged commit 944ff90 into 4.5 Aug 1, 2023
22 checks passed
@alongosz alongosz deleted the IBX-5932_Image_Variation_Selection_cut_off branch August 1, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@tischsoic tischsoic tischsoic approved these changes

@mnocon mnocon mnocon approved these changes

@dew326 dew326 dew326 approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@Gengar-i Gengar-i Gengar-i approved these changes

Assignees

@alongosz alongosz

@dew326 dew326

@mateuszdebinski mateuszdebinski

Labels
Bug Something isn't working QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mateuszdebinski @GrabowskiM @tischsoic @mnocon @dew326 @lucasOsti @Gengar-i @alongosz