Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-6313: Fixed anchor in empty paragraph #125

Merged
merged 2 commits into from
Aug 29, 2023
Merged

IBX-6313: Fixed anchor in empty paragraph #125

merged 2 commits into from
Aug 29, 2023

Conversation

dew326
Copy link
Contributor

@dew326 dew326 commented Aug 24, 2023

Question Answer
JIRA issue https://issues.ibexa.co/browse/IBX-6313
Bug/Improvement yes
New feature no
Target version 4.5
BC breaks no
Tests pass yes
Doc needed no

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@dew326 dew326 self-assigned this Aug 24, 2023
@bogusez bogusez self-assigned this Aug 28, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bogusez
Copy link

bogusez commented Aug 29, 2023

Regression tests passed:
ibexa/content#98
ibexa/experience#229
ibexa/commerce#358

Only known issues detected.

@dew326 dew326 merged commit 397ff27 into 4.5 Aug 29, 2023
19 of 22 checks passed
@dew326 dew326 deleted the empty-anchor branch August 29, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@Gengar-i Gengar-i Gengar-i approved these changes

@bogusez bogusez bogusez approved these changes

@tischsoic tischsoic Awaiting requested review from tischsoic

Assignees

@alongosz alongosz

@dew326 dew326

@bogusez bogusez

Labels
QA approved Ready for MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dew326 @bogusez @GrabowskiM @lucasOsti @Gengar-i @alongosz