IBX-8340: RichText: Not possible to create a link to a custom route #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dew326
approved these changes
Jun 6, 2024
lucasOsti
approved these changes
Jun 12, 2024
GrabowskiM
approved these changes
Jun 12, 2024
tischsoic
approved these changes
Jun 12, 2024
src/bundle/Resources/public/js/CKEditor/link/ui/link-form-view.js
Outdated
Show resolved
Hide resolved
|
@vidarl Could you please apply feedback from @tischsoic and mark PR as ready for QA? |
Co-authored-by: Jakub Brzegowski <symfiz@gmail.com>
|
done |
|
Thank you @vidarl! |
This was referenced Jul 1, 2024
bogusez
approved these changes
Jul 1, 2024
adamwojs
deleted the
IBX-8340_Not_possible_to_create_a_link_to_a_custom_route
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
It's not possible to create a link to a custom route. In the link modal:
New editor should behave in the same way as the old one (alloy) in 3.3:
Links will not be site-access aware ( so
/foobarwon't be translated to/admin/foobaror/pl/foobar) but this was not the case in 3.3 either