Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-4417: Fixed DomainContentResolver #48

Merged
merged 2 commits into from
Feb 16, 2023

Conversation

barw4
Copy link
Contributor

@barw4 barw4 commented Feb 15, 2023

@barw4 barw4 added Bug Something isn't working Ready for review labels Feb 15, 2023
@barw4 barw4 requested a review from a team February 15, 2023 16:08
@barw4 barw4 self-assigned this Feb 15, 2023
@micszo micszo self-assigned this Feb 16, 2023
Copy link

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Original exception is gone but different error showed up:

{
  "errors": [
    {
      "debugMessage": "Call to undefined method Ibexa\\Contracts\\Core\\Repository\\Values\\Content\\ContentInfo::getName()",
      "message": "Internal server Error",
      "extensions": {
        "category": "internal"
      },
      "locations": [
        {
          "line": 8,
          "column": 7
        }
      ],
      "path": [
        "uploadFiles",
        "files",
        0,
        "_name"
      ],
      "trace": (...)

Also Sub items disappeared:

Screenshot 2023-02-16 at 11 30 12

@barw4
Copy link
Contributor Author

barw4 commented Feb 16, 2023

Seems like the original intention was to rely on Content, not on ContentInfo, therefore I went the opposite way, should be all good now

@sonarcloud
Copy link

sonarcloud bot commented Feb 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both errors are gone. 🎉

QA Approved on Ibexa Commerce 4.3.4-dev.

@micszo micszo removed their assignment Feb 16, 2023
@webhdx webhdx merged commit 7e0d05e into 4.3 Feb 16, 2023
@webhdx webhdx deleted the ibx-4417-fix-DomainContentResolver branch February 16, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants