Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-7979: Fixed "field" keyword occurrences in fields' identifiers being wrongly replaced #61

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

konradoboza
Copy link
Contributor

JIRA: https://issues.ibexa.co/browse/IBX-7979

Followup for #59 where return was performed too early. I added also some more strict regular expression targeting only actual usage of field keyword within fields' identifiers with case-insensitivity taken into account.

@konradoboza konradoboza added Bug Something isn't working Ready for review labels Mar 20, 2024
@konradoboza konradoboza changed the title IBX-7979: Fixed "field" occurrences in fields' identifiers being wrongly replaced IBX-7979: Fixed "field" keyword occurrences in fields' identifiers being wrongly replaced Mar 20, 2024
@konradoboza konradoboza requested a review from a team March 20, 2024 14:19
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a bit error-prone then, so perhaps we need some unit test coverage to consider all the cases?

@alongosz alongosz requested a review from a team March 25, 2024 13:15
@konradoboza
Copy link
Contributor Author

This seems a bit error-prone then, so perhaps we need some unit test coverage to consider all the cases

That would technically mean adding test coverage to entire GraphQL API layer. 😞

@konradoboza konradoboza force-pushed the ibx-7979-fix-field-keyword-replacing branch from 4c6a1a5 to f8f33a6 Compare April 8, 2024 13:37
@konradoboza konradoboza changed the base branch from 4.5 to 4.6 April 8, 2024 13:37
Copy link

sonarcloud bot commented Apr 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP 4.6 commerce.

@konradoboza konradoboza merged commit 52efc46 into 4.6 Apr 11, 2024
10 of 11 checks passed
@konradoboza konradoboza deleted the ibx-7979-fix-field-keyword-replacing branch April 11, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working QA approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants