Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-2919: Added missing PHP sodium extension for OSS edition #44

Merged
merged 1 commit into from
May 19, 2022
Merged

IBX-2919: Added missing PHP sodium extension for OSS edition #44

merged 1 commit into from
May 19, 2022

Conversation

micszo
Copy link
Contributor

@micszo micszo commented May 19, 2022 •
edited
Loading

Question Answer
JIRA issue IBX-2919
Type bug
Target Ibexa version v3.3
BC breaks no

Added missing PHP sodium extension for OSS edition.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@micszo micszo added Bug Something isn't working Ready for review labels May 19, 2022
webhdx
webhdx approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@webhdx webhdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has to be added to 4.0, 4.0.x-dev, 4.1, 4.1.x-dev and 4.2.x-dev during merge up.

@webhdx webhdx merged commit 601e70b into 1.0 May 19, 2022
@webhdx webhdx deleted the ibx-2919 branch May 19, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@webhdx webhdx webhdx approved these changes

@kmadejski kmadejski kmadejski approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@micszo @adamwojs @webhdx @kmadejski