Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed PHPStan failing on PHP 8.1 #58

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Fixed PHPStan failing on PHP 8.1 #58

merged 1 commit into from
Jan 9, 2023

Conversation

Steveb-p
Copy link
Contributor

@Steveb-p Steveb-p commented Jan 9, 2023

Question Answer
JIRA issue N/A
Type improvement
Target Ibexa version v4.3
BC breaks no

Updated PHPStan, which fixes the issue found in #57.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@Steveb-p Steveb-p requested a review from a team January 9, 2023 12:43
@konradoboza konradoboza requested a review from a team January 9, 2023 12:44
@adamwojs adamwojs merged commit d415a33 into 4.3 Jan 9, 2023
@adamwojs adamwojs deleted the fix-phpstan branch January 9, 2023 13:57
@adamwojs adamwojs mentioned this pull request Jan 9, 2023
Merged
2 tasks
@Steveb-p
Copy link
Contributor Author

Merged up into main in b6d111a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@ciastektk ciastektk ciastektk approved these changes

@konradoboza konradoboza konradoboza approved these changes

Assignees

@adamwojs adamwojs

@Steveb-p Steveb-p

@Nattfarinn Nattfarinn

@webhdx webhdx

Labels
Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Steveb-p @adamwojs @ciastektk @konradoboza @Nattfarinn @webhdx