Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-8140: Enabled authenticator manager-based security #118

Conversation

konradoboza
Copy link
Contributor

@konradoboza konradoboza commented May 9, 2024

🎫 Issue IBX-8140

This PR is about switching to the new authorization mechanism that was introduced as part of Symfony 5.4 release. The main trigger allowing us to rely on the new mechanism from now on is setting enable_authenticator_manager: true. All the related PRs adapt the existing codebase and base functionalities like login/logout/redirect to work with the new setup.

The most important part is not having a token for anonymous users which forces us to revisit the approach to such users. In practice we need to deal with null value instead of token for anonymous users.

Related PRs:

Description:

For QA:

Documentation:

We should mention that those changes are necessary due to switching to the new auth system coming from Symfony (ref: https://symfony.com/doc/5.x/security.html):

Symfony Security has received major changes in 5.3. This article explains the new authenticator-based system (identified by the enable_authenticator_manager: true config option).

Refer to the [5.2 version of this documentation](https://symfony.com/doc/5.2/security.html) if you're still using the legacy security system.

Copy link

github-actions bot commented May 9, 2024

Thanks for contribution! 🎉

To test the changes please execute:

composer config extra.symfony.endpoint https://api.github.com/repos/ibexa/recipes-dev/contents/index.json?ref=flex/pull-118

before executing the recipes.

@konradoboza konradoboza force-pushed the ibx-8140-enable-authorization-with-new-authenticator-mechanisms branch from 5dc1cd7 to 6e444cb Compare May 20, 2024 10:40
Copy link

sonarcloud bot commented May 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@alongosz alongosz requested a review from a team May 21, 2024 10:28
@konradoboza konradoboza requested a review from a team May 22, 2024 07:05
@konradoboza konradoboza added the Doc needed The changes require some documentation label May 23, 2024
@konradoboza konradoboza merged commit cf3ce7f into master May 23, 2024
2 checks passed
@konradoboza konradoboza deleted the ibx-8140-enable-authorization-with-new-authenticator-mechanisms branch May 23, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Doc needed The changes require some documentation Feature New feature request Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants