[Tests] Added coverage for the change

ibexa · Jun 27, 2023 · 6cb1ff5 · 6cb1ff5
1 parent 5a847d5
commit 6cb1ff5
Show file tree

Hide file tree

Showing 5 changed files with 42 additions and 0 deletions.
diff --git a/tests/lib/Output/Generator/JsonTest.php b/tests/lib/Output/Generator/JsonTest.php
@@ -241,6 +241,14 @@ public function testGeneratorValueList()
         );
     }
 
+    public function assertSnapshot(string $snapshotName, string $generatedContent): void
+    {
+        self::assertJsonStringEqualsJsonFile(
+            sprintf('%s/_fixtures/%s.json', __DIR__, $snapshotName),
+            $generatedContent
+        );
+    }
+
     public function testGetMediaType()
     {
         $generator = $this->getGenerator();

diff --git a/tests/lib/Output/Generator/XmlTest.php b/tests/lib/Output/Generator/XmlTest.php
@@ -241,6 +241,14 @@ public function testGeneratorValueList()
         );
     }
 
+    public function assertSnapshot(string $snapshotName, string $generatedContent): void
+    {
+        self::assertXmlStringEqualsXmlFile(
+            sprintf('%s/_fixtures/%s.xml', __DIR__, $snapshotName),
+            $generatedContent
+        );
+    }
+
     public function testGetMediaType()
     {
         $generator = $this->getGenerator();

diff --git a/tests/lib/Output/Generator/_fixtures/testStartValueElementWithAttributes.json b/tests/lib/Output/Generator/_fixtures/testStartValueElementWithAttributes.json
@@ -0,0 +1 @@
+{"Element":{"_media-type":"application\/vnd.ibexa.api.Element+json","element":{"_attribute1":"attribute_value1","_attribute2":"attribute_value2","#text":"value"}}}
diff --git a/tests/lib/Output/Generator/_fixtures/testStartValueElementWithAttributes.xml b/tests/lib/Output/Generator/_fixtures/testStartValueElementWithAttributes.xml
@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<Element media-type="application/vnd.ibexa.api.Element+xml">
+    <element attribute1="attribute_value1" attribute2="attribute_value2">value</element>
+</Element>
diff --git a/tests/lib/Output/GeneratorTest.php b/tests/lib/Output/GeneratorTest.php
@@ -185,6 +185,27 @@ public function testNonEmptyDocument()
 
         $this->assertFalse($generator->isEmpty());
     }
+
+    abstract protected function assertSnapshot(string $snapshotName, string $generatedContent): void;
+
+    public function testStartValueElementWithAttributes(): void
+    {
+        $generator = $this->getGenerator();
+        $generator->startDocument('test');
+        $generator->startObjectElement('Element');
+        $generator->startValueElement(
+            'element',
+            'value',
+            [
+                'attribute1' => 'attribute_value1',
+                'attribute2' => 'attribute_value2',
+            ]
+        );
+        $generator->endValueElement('element');
+        $generator->endObjectElement('Element');
+
+        static::assertSnapshot(__FUNCTION__, $generator->endDocument('test'));
+    }
 }
 
 class_alias(GeneratorTest::class, 'EzSystems\EzPlatformRest\Tests\Output\GeneratorTest');