Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7275: Added ValueObjectVisitor for Content Field #79

Merged
merged 6 commits into from
Dec 11, 2023
Merged

IBX-7275: Added ValueObjectVisitor for Content Field #79

merged 6 commits into from
Dec 11, 2023

Conversation

ciastektk
Copy link
Contributor

@ciastektk ciastektk commented Dec 6, 2023 •
edited
Loading

Question Answer
JIRA issue IBX-7275
Type improvement
Target version v4.6
BC breaks no
Tests pass yes
Doc needed no

This PR adds dedicated ValueObjectVisitor for Content Field objects, that allows to generate correct REST output for fields.

There is also added new method serializeContentFieldValue to FieldTypeSerializer to serialize field value based on passed Field object.

TODO:

  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@ciastektk ciastektk mentioned this pull request Dec 6, 2023
Merged
2 tasks
@ciastektk ciastektk requested a review from a team December 7, 2023 07:17
@ciastektk ciastektk force-pushed the ibx-7275-added-visitor-for-content-field branch from 471cadc to f496c8d Compare December 7, 2023 07:40
@ciastektk ciastektk force-pushed the ibx-7275-added-visitor-for-content-field branch from f496c8d to c7fa4ab Compare December 7, 2023 08:14
alongosz
alongosz approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 but one more test would be nice to have:

tests/lib/Server/Output/ValueObjectVisitor/VersionTest.php Show resolved Hide resolved
@alongosz alongosz requested a review from a team December 7, 2023 09:03
@webhdx
Copy link
Contributor

webhdx commented Dec 7, 2023

Yeah fully agree we need to add missing tests later. Please @ciastektk keep it on your radar. We should have more time for that during certification phase.

@webhdx webhdx requested a review from a team December 7, 2023 10:44
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ciastektk
Copy link
Contributor Author

@webhdx, @alongosz Unit test for new Visitor: 747f725

@alongosz alongosz requested a review from a team December 7, 2023 11:16
@alongosz alongosz merged commit 4315d42 into main Dec 11, 2023
12 checks passed
@alongosz alongosz deleted the ibx-7275-added-visitor-for-content-field branch December 11, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alongosz alongosz alongosz approved these changes

@webhdx webhdx webhdx approved these changes

@mnocon mnocon mnocon approved these changes

Assignees

@Steveb-p Steveb-p

@alongosz alongosz

@ViniTou ViniTou

Labels
Improvement QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ciastektk @webhdx @alongosz @mnocon @Steveb-p @ViniTou