Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-7409: Changed Content Type to content type #83

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

Gengar-i
Copy link
Contributor

@Gengar-i Gengar-i commented Jan 3, 2024

Question Answer
JIRA issue IBX-7409
Type bug
Target version e.g.: Ibexa v4.6
BC breaks yes
Tests pass yes
Doc needed no

Changed Content Type to Content type

TODO:

  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@Gengar-i Gengar-i changed the title IBX-7409: Changed Content Type to Content type IBX-7409: Changed Content Type to content type Jan 8, 2024
@Gengar-i Gengar-i force-pushed the ibx-7409-changed-content-type-label branch from e0b18ef to 9ff765b Compare January 9, 2024 15:00
Copy link

sonarcloud bot commented Jan 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

5.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't be myself, if I didn't point out that changing remote API exception response is a BC break. But I guess we need to accept it on a commercially reasonable basis and move on ;-)

Sonar analysis, while correct, completely out of scope here and in this particular case can be ignored.

@alongosz alongosz requested a review from a team January 10, 2024 11:04
@Nattfarinn Nattfarinn merged commit b420bb5 into main Jan 22, 2024
11 of 12 checks passed
@Nattfarinn Nattfarinn deleted the ibx-7409-changed-content-type-label branch January 22, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants