Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-5697: [Dropdown] Change default placeholder to "All" #22

Merged
merged 1 commit into from
May 10, 2023
Merged

IBX-5697: [Dropdown] Change default placeholder to "All" #22

merged 1 commit into from
May 10, 2023

Conversation

GrabowskiM
Copy link
Contributor

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-5697
Bug fix? no
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

With ibexa/admin-ui#780

Checklist:

  • Implement tests
  • Coding standards ($ composer fix-cs)

@sonarcloud
Copy link

sonarcloud bot commented May 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tomaszszopinski tomaszszopinski self-assigned this May 9, 2023
@tomaszszopinski tomaszszopinski mentioned this pull request May 9, 2023
Merged
2 tasks
tomaszszopinski
tomaszszopinski approved these changes May 9, 2023
View reviewed changes
Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP commerce 4.5

@dew326 dew326 merged commit 845d7ee into main May 10, 2023
@dew326 dew326 deleted the IBX-5697-change-dropdown-placeholder branch May 10, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tischsoic tischsoic tischsoic approved these changes

@dew326 dew326 dew326 approved these changes

@ViniTou ViniTou ViniTou approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@Gengar-i Gengar-i Gengar-i approved these changes

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

Assignees

@adamwojs adamwojs

@ViniTou ViniTou

@tomaszszopinski tomaszszopinski

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@GrabowskiM @tischsoic @dew326 @ViniTou @lucasOsti @Gengar-i @tomaszszopinski @adamwojs