Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-3639: As an Editor I'd like use facets to filter global search results #26

Merged
merged 4 commits into from
Sep 15, 2023

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Aug 15, 2023

Question Answer
Tickets IBX-6339
Bug fix? no
New feature? yes
BC breaks? no
Tests pass? yes
Doc needed? yes
License GPL-2.0

Checklist:

  • Implement tests
  • Coding standards ($ composer fix-cs)

@adamwojs adamwojs changed the title IBX-3639: As an editor I'd like use facets to filter global search results IBX-3639: As an Editor I'd like use facets to filter global search results Aug 15, 2023
@webhdx webhdx requested a review from a team August 21, 2023 06:36
@webhdx webhdx added Feature New feature request Ready for review labels Aug 21, 2023
@bogusez
Copy link

bogusez commented Sep 6, 2023

@adamwojs searching for content name in global search causes an exception with error code 500
The issue occurred on legacy search engine.

Screenshot 2023-09-06 at 09 31 00

@adamwojs
Copy link
Member Author

adamwojs commented Sep 8, 2023

@bogusez You can continue testing, issue should be fixed now.

@bogusez
Copy link

bogusez commented Sep 11, 2023

@adamwojs when I do a reindex and then I open page {host}/admin/search an error 500 occurs (Legacy search engine).

Screenshot 2023-09-11 at 11 13 28

@adamwojs
Copy link
Member Author

@bogusez Fixed in ibexa/admin-ui@786eec0. You can continue testing.

@bogusez
Copy link

bogusez commented Sep 15, 2023

Regression tests passed:
ibexa/headless#17
ibexa/experience#233
ibexa/commerce#377

@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kisztof kisztof merged commit e28b908 into main Sep 15, 2023
10 checks passed
@adamwojs adamwojs deleted the ibx_6339 branch September 16, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants