Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused imports narrowed down via composer-unused tool #47

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

konradoboza
Copy link
Contributor

@konradoboza konradoboza commented Feb 15, 2024

Also, performed some additional cleanup within composer.json.

Copy link

sonarcloud bot commented Feb 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side topic, for a follow-up:

$ composer validate
./composer.json is valid, but with a few warnings
See https://getcomposer.org/doc/04-schema.md for details on the schema
# General warnings
- License "GPL-2.0" is a deprecated SPDX license identifier, use "GPL-2.0-only" or "GPL-2.0-or-later" instead

Correct one for OSS: https://github.com/ibexa/core/blob/main/composer.json#L5

@alongosz alongosz merged commit 808017d into main Feb 16, 2024
14 checks passed
@alongosz alongosz deleted the unused-dependencies branch February 16, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants