Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-2829: Added option to configure fields for register form #40

Merged
merged 7 commits into from
Jun 23, 2022
Merged

IBX-2829: Added option to configure fields for register form #40

merged 7 commits into from
Jun 23, 2022

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented May 27, 2022 •
edited
Loading

Question Answer
Tickets IBX-2829
Bug fix? no
New feature? yes
BC breaks? no
Tests pass? yes/no
Doc needed? yes
License GPL-2.0 
ibexa:
    system:
        <sa-key>:
            user_registration:
                form:
                    allowed_field_definitions_identifiers:
                        - field_one
                        - field_two

Checklist:

  • Coding standards ($ composer fix-cs)

@ViniTou ViniTou requested a review from a team May 30, 2022 12:06
@ViniTou ViniTou added the Doc needed The changes require some documentation label May 30, 2022
@Nattfarinn Nattfarinn requested a review from a team June 14, 2022 08:17
konradoboza
konradoboza approved these changes Jun 14, 2022
View reviewed changes
src/lib/Form/Type/UserRegisterType.php Outdated Show resolved Hide resolved
@konradoboza konradoboza requested a review from a team June 14, 2022 08:17
Steveb-p
Steveb-p approved these changes Jun 14, 2022
View reviewed changes
src/lib/Form/Type/UserRegisterType.php Outdated Show resolved Hide resolved
tomaszszopinski
tomaszszopinski approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on Ibexa DXP commerce 4.2.

@ViniTou ViniTou merged commit c3cf31d into main Jun 23, 2022
@ViniTou ViniTou deleted the ibx-2829-configure-register-form branch June 23, 2022 07:25
@MagdalenaZuba MagdalenaZuba mentioned this pull request Jun 29, 2022
Merged
@MagdalenaZuba MagdalenaZuba removed the Doc needed The changes require some documentation label Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steveb-p Steveb-p Steveb-p approved these changes

@damianz5 damianz5 damianz5 approved these changes

@Nattfarinn Nattfarinn Nattfarinn approved these changes

@alongosz alongosz alongosz approved these changes

@konradoboza konradoboza konradoboza approved these changes

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

Assignees

@mikadamczyk mikadamczyk

@Steveb-p Steveb-p

@ViniTou ViniTou

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@ViniTou @Steveb-p @damianz5 @Nattfarinn @alongosz @konradoboza @tomaszszopinski @mikadamczyk @MagdalenaZuba