Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-3514: Extracted isExpired method #47

Merged
merged 4 commits into from
Aug 8, 2022
Merged

IBX-3514: Extracted isExpired method #47

merged 4 commits into from
Aug 8, 2022

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Aug 4, 2022

Question Answer
Tickets IBX-3514

@ViniTou ViniTou changed the title IBX-3514: Extraced isExpired method IBX-3514: Extracted isExpired method Aug 4, 2022
@ViniTou ViniTou requested a review from a team August 4, 2022 12:45
@konradoboza konradoboza requested a review from a team August 4, 2022 13:15
alongosz
alongosz reviewed Aug 4, 2022
View reviewed changes
src/lib/Form/Type/Invitation/InvitationType.php

public function buildForm(FormBuilderInterface $builder, array $options)
{
$builder->addViewTransformer(new InvitationTransformer($this->invitationService));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an expert on Forms, but can we make InvitationTransformer as a service as well and inject that, instead of instantiating it?
Brief look at the doc would suggest rather that, unless I missed something.

@ViniTou @konradoboza
Update src/lib/Templating/Twig/InvitationExtension.php
c67695e 
Co-authored-by: Konrad Oboza <konrad.oboza@ibexa.co>
@sonarcloud
Copy link

sonarcloud bot commented Aug 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Steveb-p
Steveb-p approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@Steveb-p Steveb-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for Andrew's comment though.

@ViniTou ViniTou merged commit 565cac0 into main Aug 8, 2022
@ViniTou ViniTou deleted the refresh-invitations-endpoint branch August 8, 2022 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steveb-p Steveb-p Steveb-p approved these changes

@alongosz alongosz alongosz approved these changes

@mnocon mnocon mnocon approved these changes

@konradoboza konradoboza konradoboza approved these changes

Assignees

@mikadamczyk mikadamczyk

@Steveb-p Steveb-p

@ViniTou ViniTou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ViniTou @Steveb-p @alongosz @mnocon @konradoboza @mikadamczyk