Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed domain names #60

Merged
merged 3 commits into from
Sep 5, 2023
Merged

Renamed domain names #60

merged 3 commits into from
Sep 5, 2023

Conversation

mikadamczyk
Copy link
Contributor

@mikadamczyk mikadamczyk commented Aug 16, 2023

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-6415
Bug fix? no
New feature? no
BC breaks? no
Tests pass? no
Doc needed? no
License GPL-2.0

Added ibexa prefix to the domain names

Checklist:

  • Implement tests
  • Coding standards ($ composer fix-cs)

@mikadamczyk mikadamczyk self-assigned this Aug 16, 2023
@ViniTou ViniTou self-requested a review August 17, 2023 08:38
@@ -147,8 +147,8 @@
<note>key: settings.timezone.value.title</note>
</trans-unit>
<trans-unit id="7f90e23e086f56c5f7b4a82c6e4b8f40732e6e6a" resname="user_setting.update.success">
<source>User setting '%identifier%' updated.</source>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesent look like changed domain name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an effect of translation extraction.

/** @Desc("User settings '%identifier%' updated.") */

It looks like the translation wasn't regenerated after a change of description

Copy link
Contributor

@ViniTou ViniTou Aug 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it was me, but I do not know why I decided to change single form to plural, anyway 👍

@ViniTou ViniTou self-requested a review August 17, 2023 08:40
@mikadamczyk mikadamczyk requested a review from a team August 17, 2023 10:55
@konradoboza konradoboza requested a review from a team August 17, 2023 11:13
@sonarcloud
Copy link

sonarcloud bot commented Sep 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

1 similar comment
@sonarcloud
Copy link

sonarcloud bot commented Sep 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mikadamczyk mikadamczyk merged commit f0ec083 into main Sep 5, 2023
15 checks passed
@mikadamczyk mikadamczyk deleted the renamed-domain-names branch September 5, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants