Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-7870: Fixed an old product name in "Change password" screen #75

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

mikadamczyk
Copy link
Contributor

@mikadamczyk mikadamczyk commented Mar 13, 2024

Question Answer
Tickets IBX-7870
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Companion PR: ibexa/admin-ui#1204

The correct translation added in ibexa/admin-ui#1204 was overwritten by an outdated translation key present in this package (https://github.com/ibexa/user/compare/ibx-7870-change-password-wrong-product-name?expand=1#diff-fc54d07c9121de0ecf10e28736fa4c69f6e811c8f35b03d18f0a11ba1ef6a353L63). I extracted all translations and obsolete keys were removed.

Checklist:

  • Implement tests
  • Coding standards ($ composer fix-cs)

@mikadamczyk mikadamczyk added the Bug Something isn't working label Mar 13, 2024
@mikadamczyk mikadamczyk requested review from konradoboza and a team March 13, 2024 12:38
@mikadamczyk mikadamczyk self-assigned this Mar 13, 2024
@mikadamczyk mikadamczyk changed the base branch from main to 4.5 March 13, 2024 12:38
Copy link

sonarcloud bot commented Mar 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@konradoboza konradoboza requested a review from a team March 13, 2024 12:39
@ViniTou ViniTou merged commit f67ad5f into 4.5 Mar 14, 2024
7 checks passed
@ViniTou ViniTou deleted the ibx-7870-change-password-wrong-product-name branch March 14, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working QA approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants