-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support yyjson_mut_obj_add_obj
& yyjson_mut_obj_add_arr
like yyjson_mut_arr_add_*
#140
Comments
yyjson_mut_obj_add_obj
& yyjson_mut_obj_add_arr
yyjson_mut_obj_add_obj
& yyjson_mut_obj_add_arr
like yyjson_mut_arr_add_*
Thanks! The two missing functions have been added. |
What about a new release? |
It's released every six months and the next one should be in Dec. |
The problem is that fastfetch will release a new version soon, and it uses these two new functions. I have updated the embed yyjson source in fastfetch source tree. However some package managers prefer system installed yyjson package. These two fns doesn't exist in 0.6.0 so that fastfetch build will fail. Even if I revert the upgrade-yyjson commit in fastfetch, once new version of yyjson is released, fastfetch build will fail because of the duplicated So that new version of fastfetch must be released after new version of yyjson. Any ideas? |
I see, in that case, let's go ahead and release a new version. |
Needs >=0.8.0 for yyjson_mut_obj_add_obj. Bug: ibireme/yyjson#140 Signed-off-by: Sam James <sam@gentoo.org>
Needs >=0.8.0 for yyjson_mut_obj_add_obj. Bug: ibireme/yyjson#140 Signed-off-by: Sam James <sam@gentoo.org>
Is your feature request related to a problem? Please describe.
We do have
yyjson_mut_arr_add_obj
andyyjson_mut_arr_add_arr
but notyyjson_mut_obj_add_obj
andyyjson_mut_obj_add_arr
, which seems strange.Describe the solution you'd like
Describe alternatives you've considered
I add it manually to my repo, but I think it would be better if yyjson supports it natively
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: