Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(polars): implement .sql methods #6323

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented May 27, 2023

This PR implements con.sql and Table.sql support for the polars backends. A lot of functionality subqueries are not implemented yet (and we generate a lot of them), but the various test_dot_sql.py tests should start to XPASS once support is implemented upstream.

@cpcloud cpcloud added this to the 6.0 milestone May 27, 2023
@cpcloud cpcloud added feature Features or general enhancements polars The polars backend labels May 27, 2023
@kszucs
Copy link
Member

kszucs commented Jun 5, 2023

@cpcloud needs a rebase

Copy link
Member

@kszucs kszucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nits other than that it looks good to me.

@cpcloud cpcloud enabled auto-merge (rebase) June 5, 2023 15:32
@cpcloud cpcloud merged commit 86f2a34 into ibis-project:master Jun 5, 2023
@cpcloud cpcloud deleted the polars-dot-sql branch June 5, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Features or general enhancements polars The polars backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants