feat: implement read_delta for datafusion #6411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibis/backends/datafusion/__init__.py
Outdated
| # Our other backends support overwriting views / tables when reregistering | ||
| # TODO: datafusion doesn't natively support Delta Lake tables at this point, | ||
| # so we need to add this later? | ||
| # self._context.deregister_table(table_name) |
There was a problem hiding this comment.
or should this line be uncommented still?
There was a problem hiding this comment.
I don't think whether support is native or not matters here, so this line should be uncommented.
There was a problem hiding this comment.
that results in an error:
> self._context.register_delta(table_name, source_table, **kwargs)
E AttributeError: 'datafusion.SessionContext' object has no attribute 'register_delta'
ibis/backends/datafusion/__init__.py:275: AttributeError
cpcloud
added
datafusion
lostmygithubaccount
force-pushed
the
delta-datafusion
branch
from
ef4a53d
to
7faaf3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6384
one question is noted in the TODO -- my understanding is for csv and parquet we're using a native datafusion function for de-registering the files from the database, but we can't do that with delta yet?
datafusion has an issue open for native support: apache/datafusion#2025
also cleaned up a docstring issue I noticed in duckdb