Add course to launch gate and api #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Since we have an org in the url context, the allowed_orgs must only be able to be empty or that value - Also any courses/keys must be within the target org
- ListField must call str(obj) b/c what's writtedn to the db isn't json - This handles a text-backed db field
- We don't want this exposed at all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allowed_coursestoLaunchGatemodel so admin could restrict launch targets to all content within a given courseallowed_orgssince that needs to be set automaticallyallow_all_within_orgbool which a user could set instead and automatically sets theallowed_orgsappropriatelyCloses #25