Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support high contrast mode detection #424

Closed
wkeese opened this issue Sep 6, 2015 · 0 comments
Closed

support high contrast mode detection #424

wkeese opened this issue Sep 6, 2015 · 0 comments
Assignees
@wkeese
Labels
feature
Milestone
0.8.0

Comments

@wkeese
Copy link
Member

wkeese commented Sep 6, 2015

Most widgets don't need special code to support high-contrast mode, because when the user sets the OS to high-contrast mode, the browser automatically changes text color and font-size according to the OS's setting.

However, deliteful/ProgressIndicator is an exception because it uses SVG, and the browser does not adjust the colors within SVG DOM.

Therefore, add high-contrast detection code to delite, similar to dojo core's hccss.js.

Some possible debate points about this PR:

  • should it set the CSS class on <body>, or just define has("highcontrast")?
  • relatedly, should the code be in a separate hc.js module, or rolled into features.js?

See also ibm-js/deliteful#585.
@wkeese wkeese added the feature label Sep 6, 2015
@wkeese wkeese self-assigned this Sep 6, 2015
@wkeese wkeese added this to the 0.8.0 milestone Sep 6, 2015
wkeese added a commit to wkeese/delite that referenced this issue Sep 7, 2015
@wkeese
support high-contrast detection, fixes ibm-js#424
3d9f1b8
wkeese added a commit to wkeese/delite that referenced this issue Sep 7, 2015
@wkeese
support high-contrast detection, fixes ibm-js#424
16a1a49
wkeese added a commit to wkeese/delite that referenced this issue Sep 7, 2015
@wkeese
support high-contrast detection, fixes ibm-js#424
08a7f1c
wkeese added a commit to wkeese/deliteful that referenced this issue Sep 7, 2015
@wkeese
ProgressIndicator: leverage delite's has("highcontrast") code.
f65c958 
Also move code from attachedCallback() to postRender().

Refs ibm-js/delite#424.
@wkeese wkeese mentioned this issue Sep 7, 2015
Merged
@wkeese wkeese closed this as completed in 018f49a Sep 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wkeese wkeese

Labels
feature
Projects
None yet
Milestone
0.8.0
Development

No branches or pull requests
1 participant
@wkeese