[minor] Gitops updates to support junitreporter + timeouts in FVT #1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitfiea
requested review from
durera,
JonahLuckett,
andrercm,
sanjayprab,
terenceq,
alequint and
leo-miran
as code owners
tomklapiscak
approved these changes
Sep 27, 2024
karol-czarnecki
added a commit
that referenced
this pull request
Oct 4, 2024
commit 9736129 Author: anilprajapatiibm <169060963+anilprajapatiibm@users.noreply.github.com> Date: Fri Oct 4 20:18:17 2024 +0530 [minor] Support October Catalog (#1234) Co-authored-by: Ian Boden <ianboden@uk.ibm.com> commit 6e1e2ae Author: Alexandre Quinteiro <alefq0@gmail.com> Date: Wed Oct 2 15:04:28 2024 -0300 [minor] Reorganize scheduler tests - removed selenium and added pytests (#1278) Co-authored-by: Alexandre Quinteiro <alequint@Alexandres-MBP.lan> commit 6df29d8 Author: stonepd <stonepd@uk.ibm.com> Date: Wed Oct 2 17:18:17 2024 +0100 [patch] Provide CLI automation to upgrade CPD v4.8 installations to v5.0 (#1270) commit 6420049 Author: Terence Quinn <quinnt@us.ibm.com> Date: Tue Oct 1 13:47:36 2024 -0500 [patch] add node about zenmetastore-edb postgres license issue (#1277) commit dccbe8f Author: HariPalleti <hari.palleti@ibm.com> Date: Tue Oct 1 12:56:08 2024 -0500 [patch] dro_namespace considered during update (#1276) commit 002e881 Author: mattlrx <32359792+mattlrx@users.noreply.github.com> Date: Mon Sep 30 10:27:21 2024 +0200 [minor] Mustgather update to collect additional dependencies and resources (#1268) commit 239b6b8 Author: HariPalleti <hari.palleti@ibm.com> Date: Mon Sep 30 03:20:23 2024 -0500 [patch] Fix skip_pre_check on update (#1272) commit 84d8471 Author: Andrew Whitfield <whitfiea@uk.ibm.com> Date: Sun Sep 29 13:08:35 2024 +0100 [patch] Update sls to 90 mins wait time in gitops fvt-preparer (#1274) commit b5f7aa0 Author: Andrew Whitfield <whitfiea@uk.ibm.com> Date: Sat Sep 28 19:20:58 2024 +0100 [patch] increase wait times in gitops fvt-preparer (#1273) commit 14a223a Author: Andrew Whitfield <whitfiea@uk.ibm.com> Date: Fri Sep 27 15:59:44 2024 +0100 [minor] Gitops updates to support junitreporter + timeouts in FVT (#1271) commit 4a2e6f6 Author: gabrielbonamicoibm <146848045+gabrielbonamicoibm@users.noreply.github.com> Date: Fri Sep 27 11:15:48 2024 -0300 [minor] Adding mobile version info in dashboard (#1253) Co-authored-by: Leonardo Miranda <Leo.Miranda@ibm.com> Co-authored-by: leo-miran <105313348+leo-miran@users.noreply.github.com> Co-authored-by: JonahLuckett <51744616+JonahLuckett@users.noreply.github.com> commit 806157b Author: chiragcsatani <157094209+chiragcsatani@users.noreply.github.com> Date: Fri Sep 27 19:40:08 2024 +0530 MAXMF-995- Add Prerequisite Request pages pipeline before report tests (#1269) Co-authored-by: Chirag Satani <ChiragSatani@ibm.com> Co-authored-by: leo-miran <105313348+leo-miran@users.noreply.github.com> commit cc5940a Author: David Parker <parkerda@uk.ibm.com> Date: Fri Sep 27 13:04:25 2024 +0530 [doc] Fix typo in doc home page commit fbf1ea8 Author: David Parker <parkerda@uk.ibm.com> Date: Fri Sep 27 12:52:57 2024 +0530 [doc] Update documentation home page commit 90eb01d Author: Tom Klapiscak <7372253+tomklapiscak@users.noreply.github.com> Date: Fri Sep 27 07:48:06 2024 +0100 [patch] Fix race conditions in gitops code (#1264) commit 9f890b8 Author: stonepd <stonepd@uk.ibm.com> Date: Wed Sep 25 11:17:30 2024 +0100 [patch] include default for set_finished parameter (#1267) commit a9f520d Author: David Parker <parkerda@uk.ibm.com> Date: Tue Sep 24 10:47:08 2024 +0530 [doc] Update recommended CLI version commit 54d6ed1 Author: Ian Boden <82514609+IanBoden@users.noreply.github.com> Date: Tue Sep 24 05:36:22 2024 +0100 [patch] Remove expires-after on release (#1262) Co-authored-by: David Parker <parkerda@uk.ibm.com> commit 41c56a9 Author: Tremaine Hart <twhart@us.ibm.com> Date: Mon Sep 23 13:10:00 2024 -0500 [patch] [MASCORE-3975] Create FVT test for Grafana (#1263) commit faa2f4b Author: bmoferrall <44264093+bmoferrall@users.noreply.github.com> Date: Mon Sep 23 15:26:33 2024 +0100 [patch] MAXMIS-521: fix sequencing of operational map test(s) (#1260) Co-authored-by: Brendan More O'Ferrall <mooreof@ie.ibm.com> commit cbe9075 Author: padmankosalaram <45054700+padmankosalaram@users.noreply.github.com> Date: Mon Sep 23 18:07:46 2024 +0530 [patch] Step timeout to 6.40hrs as imagescan wait for 6.30hrs (#1259) commit deb6c05 Author: David Parker <parkerda@uk.ibm.com> Date: Mon Sep 23 06:29:45 2024 +0100 [patch] Fix rogue VERSION in artifact names (#1258) commit b38b245 Author: David Parker <parkerda@uk.ibm.com> Date: Thu Sep 19 12:50:45 2024 +0100 [skip ci] Tidy up NFS Client handling commit ba4e530 Author: anilprajapatiibm <169060963+anilprajapatiibm@users.noreply.github.com> Date: Thu Sep 19 16:03:56 2024 +0530 [patch] fix table rowspan in catalog documentation (#1256) commit a7f63b3 Author: Andrew Whitfield <whitfiea@uk.ibm.com> Date: Thu Sep 19 11:24:49 2024 +0100 [minor] Add sanity tests for gitops (#1255) commit 3afa904 Author: leo-miran <105313348+leo-miran@users.noreply.github.com> Date: Wed Sep 18 14:56:41 2024 -0300 [patch] mobile pytest task performance parameter (#1239) Co-authored-by: Gabriel Bonamico <gabona@ibm.com> commit 1bd92c2 Author: Tremaine Hart <twhart@us.ibm.com> Date: Wed Sep 18 10:13:31 2024 -0500 [patch] need to check for nfs-client now (#1252) commit b685fee Author: stonepd <stonepd@uk.ibm.com> Date: Wed Sep 18 10:51:02 2024 +0100 [patch] run grafana role after catalog install (#1250) commit b0d13c5 Author: Andrew Whitfield <whitfiea@uk.ibm.com> Date: Wed Sep 18 10:35:18 2024 +0100 [patch] Update name of finally task and set max_retries correctly (#1246) commit 9e9c7fd Author: stonepd <stonepd@uk.ibm.com> Date: Tue Sep 17 10:00:37 2024 +0100 [patch] install cert manager after catalogs to avoid subscription patch failure (#1249) commit c5ccc6d Author: Andre Ferreira Guimaraes Junior <andrefgj@gmail.com> Date: Mon Sep 16 14:24:26 2024 -0300 [minor] [MSO-1655] Break down optimizer markers (#1244) Co-authored-by: Alexandre Quinteiro <alefq0@gmail.com> commit 07c8f2d Author: lyoshidaibm <lyoshida@br.ibm.com> Date: Mon Sep 16 13:28:03 2024 -0300 [patch] MAXMIS-485 - Change keywords for fvt pipeline (#1247) Co-authored-by: unnati-solanki-git <131964221+unnati-solanki-git@users.noreply.github.com> commit ab810d3 Author: jamie-nolan <jamienolan@ibm.com> Date: Mon Sep 16 11:46:25 2024 +0100 [minor] Add Operational Map to FVT. (#1245) commit 59485c9 Author: Andrew Whitfield <whitfiea@uk.ibm.com> Date: Fri Sep 13 20:27:58 2024 +0100 [patch] update gitops pipelines to use wait-for-tekton task (#1243) commit 923f5cf Author: Alexandre Quinteiro <alefq0@gmail.com> Date: Fri Sep 13 16:05:05 2024 -0300 [patch] Add cos prefix in use_hmac parameter (#1241) Co-authored-by: Alexandre Quinteiro <alequint@Alexandres-MBP.lan> Co-authored-by: Chirag Satani <ChiragSatani@ibm.com> Co-authored-by: Leonardo Miranda <Leo.Miranda@ibm.com> commit 71f07f6 Author: Andrew Whitfield <whitfiea@uk.ibm.com> Date: Thu Sep 12 15:22:42 2024 +0100 [patch] Check for no status on subscription - gitops (#1238) commit 35ea966 Author: Ian Boden <82514609+IanBoden@users.noreply.github.com> Date: Thu Sep 12 14:20:02 2024 +0100 [patch] Add support for mirroring odf dependcies that are required for 4.15 (#1235) commit 7ea23a9 Author: David Parker <parkerda@uk.ibm.com> Date: Wed Sep 11 09:39:48 2024 +0100 [doc] Fix "IBM License Key Center" link in docs commit 6c2b88b Author: David Parker <parkerda@uk.ibm.com> Date: Tue Sep 10 09:31:01 2024 +0100 [doc] Doc updates & latest CLI version update commit 8b6b7c6 Author: Vishal-patel-7 <142403240+Vishal-patel-7@users.noreply.github.com> Date: Tue Sep 10 08:53:27 2024 +0530 [minor] Added HMAC to COS role (#1228) Co-authored-by: unnati-solanki-git <131964221+unnati-solanki-git@users.noreply.github.com> commit b0035d3 Author: David Parker <parkerda@uk.ibm.com> Date: Mon Sep 9 12:28:08 2024 +0100 [doc] Minor doc updates commit b8989fc Author: David Parker <parkerda@uk.ibm.com> Date: Mon Sep 9 11:33:21 2024 +0100 [doc] Update examples commit dd6edf4 Author: David Parker <parkerda@uk.ibm.com> Date: Sun Sep 8 13:43:22 2024 +0100 [skip ci] Add EAM migration example commit 831e892 Author: Tremaine Hart <twhart@us.ibm.com> Date: Fri Sep 6 10:27:00 2024 -0500 [minor] [MASCORE-3026] implement role/tasks for new deployments of MongoDB CE v7.0 (#1232) commit 94b4f8d Author: unnati-solanki-git <131964221+unnati-solanki-git@users.noreply.github.com> Date: Fri Sep 6 18:10:00 2024 +0530 [patch] moving user timeout in the end (#1230) commit 10d7a2b Author: David Parker <parkerda@uk.ibm.com> Date: Thu Sep 5 14:44:17 2024 +0100 [doc] Update Documentation and support [doc] commit prefix commit 5268e7f Author: David Parker <parkerda@uk.ibm.com> Date: Thu Sep 5 11:47:36 2024 +0100 [major] Remove image mirroring support for UDS (#1231) commit 4bc95cf Author: Matheus Cardoso de Medeiros <38898699+RexMCM@users.noreply.github.com> Date: Thu Sep 5 06:29:44 2024 -0300 [patch] Add support for enabling special characters in ID/username field (#1176) Co-authored-by: Matheus Cardoso de Medeiros <Matheus.Cardoso@ibm.com> Co-authored-by: David Parker <parkerda@uk.ibm.com>
karol-czarnecki
added a commit
that referenced
this pull request
Oct 4, 2024
commit 9736129 Author: anilprajapatiibm <169060963+anilprajapatiibm@users.noreply.github.com> Date: Fri Oct 4 20:18:17 2024 +0530 [minor] Support October Catalog (#1234) Co-authored-by: Ian Boden <ianboden@uk.ibm.com> commit 6e1e2ae Author: Alexandre Quinteiro <alefq0@gmail.com> Date: Wed Oct 2 15:04:28 2024 -0300 [minor] Reorganize scheduler tests - removed selenium and added pytests (#1278) Co-authored-by: Alexandre Quinteiro <alequint@Alexandres-MBP.lan> commit 6df29d8 Author: stonepd <stonepd@uk.ibm.com> Date: Wed Oct 2 17:18:17 2024 +0100 [patch] Provide CLI automation to upgrade CPD v4.8 installations to v5.0 (#1270) commit 6420049 Author: Terence Quinn <quinnt@us.ibm.com> Date: Tue Oct 1 13:47:36 2024 -0500 [patch] add node about zenmetastore-edb postgres license issue (#1277) commit dccbe8f Author: HariPalleti <hari.palleti@ibm.com> Date: Tue Oct 1 12:56:08 2024 -0500 [patch] dro_namespace considered during update (#1276) commit 002e881 Author: mattlrx <32359792+mattlrx@users.noreply.github.com> Date: Mon Sep 30 10:27:21 2024 +0200 [minor] Mustgather update to collect additional dependencies and resources (#1268) commit 239b6b8 Author: HariPalleti <hari.palleti@ibm.com> Date: Mon Sep 30 03:20:23 2024 -0500 [patch] Fix skip_pre_check on update (#1272) commit 84d8471 Author: Andrew Whitfield <whitfiea@uk.ibm.com> Date: Sun Sep 29 13:08:35 2024 +0100 [patch] Update sls to 90 mins wait time in gitops fvt-preparer (#1274) commit b5f7aa0 Author: Andrew Whitfield <whitfiea@uk.ibm.com> Date: Sat Sep 28 19:20:58 2024 +0100 [patch] increase wait times in gitops fvt-preparer (#1273) commit 14a223a Author: Andrew Whitfield <whitfiea@uk.ibm.com> Date: Fri Sep 27 15:59:44 2024 +0100 [minor] Gitops updates to support junitreporter + timeouts in FVT (#1271) commit 4a2e6f6 Author: gabrielbonamicoibm <146848045+gabrielbonamicoibm@users.noreply.github.com> Date: Fri Sep 27 11:15:48 2024 -0300 [minor] Adding mobile version info in dashboard (#1253) Co-authored-by: Leonardo Miranda <Leo.Miranda@ibm.com> Co-authored-by: leo-miran <105313348+leo-miran@users.noreply.github.com> Co-authored-by: JonahLuckett <51744616+JonahLuckett@users.noreply.github.com> commit 806157b Author: chiragcsatani <157094209+chiragcsatani@users.noreply.github.com> Date: Fri Sep 27 19:40:08 2024 +0530 MAXMF-995- Add Prerequisite Request pages pipeline before report tests (#1269) Co-authored-by: Chirag Satani <ChiragSatani@ibm.com> Co-authored-by: leo-miran <105313348+leo-miran@users.noreply.github.com> commit cc5940a Author: David Parker <parkerda@uk.ibm.com> Date: Fri Sep 27 13:04:25 2024 +0530 [doc] Fix typo in doc home page commit fbf1ea8 Author: David Parker <parkerda@uk.ibm.com> Date: Fri Sep 27 12:52:57 2024 +0530 [doc] Update documentation home page commit 90eb01d Author: Tom Klapiscak <7372253+tomklapiscak@users.noreply.github.com> Date: Fri Sep 27 07:48:06 2024 +0100 [patch] Fix race conditions in gitops code (#1264) commit 9f890b8 Author: stonepd <stonepd@uk.ibm.com> Date: Wed Sep 25 11:17:30 2024 +0100 [patch] include default for set_finished parameter (#1267) commit a9f520d Author: David Parker <parkerda@uk.ibm.com> Date: Tue Sep 24 10:47:08 2024 +0530 [doc] Update recommended CLI version commit 54d6ed1 Author: Ian Boden <82514609+IanBoden@users.noreply.github.com> Date: Tue Sep 24 05:36:22 2024 +0100 [patch] Remove expires-after on release (#1262) Co-authored-by: David Parker <parkerda@uk.ibm.com> commit 41c56a9 Author: Tremaine Hart <twhart@us.ibm.com> Date: Mon Sep 23 13:10:00 2024 -0500 [patch] [MASCORE-3975] Create FVT test for Grafana (#1263) commit faa2f4b Author: bmoferrall <44264093+bmoferrall@users.noreply.github.com> Date: Mon Sep 23 15:26:33 2024 +0100 [patch] MAXMIS-521: fix sequencing of operational map test(s) (#1260) Co-authored-by: Brendan More O'Ferrall <mooreof@ie.ibm.com> commit cbe9075 Author: padmankosalaram <45054700+padmankosalaram@users.noreply.github.com> Date: Mon Sep 23 18:07:46 2024 +0530 [patch] Step timeout to 6.40hrs as imagescan wait for 6.30hrs (#1259) commit deb6c05 Author: David Parker <parkerda@uk.ibm.com> Date: Mon Sep 23 06:29:45 2024 +0100 [patch] Fix rogue VERSION in artifact names (#1258) commit b38b245 Author: David Parker <parkerda@uk.ibm.com> Date: Thu Sep 19 12:50:45 2024 +0100 [skip ci] Tidy up NFS Client handling commit ba4e530 Author: anilprajapatiibm <169060963+anilprajapatiibm@users.noreply.github.com> Date: Thu Sep 19 16:03:56 2024 +0530 [patch] fix table rowspan in catalog documentation (#1256) commit a7f63b3 Author: Andrew Whitfield <whitfiea@uk.ibm.com> Date: Thu Sep 19 11:24:49 2024 +0100 [minor] Add sanity tests for gitops (#1255) commit 3afa904 Author: leo-miran <105313348+leo-miran@users.noreply.github.com> Date: Wed Sep 18 14:56:41 2024 -0300 [patch] mobile pytest task performance parameter (#1239) Co-authored-by: Gabriel Bonamico <gabona@ibm.com> commit 1bd92c2 Author: Tremaine Hart <twhart@us.ibm.com> Date: Wed Sep 18 10:13:31 2024 -0500 [patch] need to check for nfs-client now (#1252) commit b685fee Author: stonepd <stonepd@uk.ibm.com> Date: Wed Sep 18 10:51:02 2024 +0100 [patch] run grafana role after catalog install (#1250) commit b0d13c5 Author: Andrew Whitfield <whitfiea@uk.ibm.com> Date: Wed Sep 18 10:35:18 2024 +0100 [patch] Update name of finally task and set max_retries correctly (#1246) commit 9e9c7fd Author: stonepd <stonepd@uk.ibm.com> Date: Tue Sep 17 10:00:37 2024 +0100 [patch] install cert manager after catalogs to avoid subscription patch failure (#1249) commit c5ccc6d Author: Andre Ferreira Guimaraes Junior <andrefgj@gmail.com> Date: Mon Sep 16 14:24:26 2024 -0300 [minor] [MSO-1655] Break down optimizer markers (#1244) Co-authored-by: Alexandre Quinteiro <alefq0@gmail.com> commit 07c8f2d Author: lyoshidaibm <lyoshida@br.ibm.com> Date: Mon Sep 16 13:28:03 2024 -0300 [patch] MAXMIS-485 - Change keywords for fvt pipeline (#1247) Co-authored-by: unnati-solanki-git <131964221+unnati-solanki-git@users.noreply.github.com> commit ab810d3 Author: jamie-nolan <jamienolan@ibm.com> Date: Mon Sep 16 11:46:25 2024 +0100 [minor] Add Operational Map to FVT. (#1245) commit 59485c9 Author: Andrew Whitfield <whitfiea@uk.ibm.com> Date: Fri Sep 13 20:27:58 2024 +0100 [patch] update gitops pipelines to use wait-for-tekton task (#1243) commit 923f5cf Author: Alexandre Quinteiro <alefq0@gmail.com> Date: Fri Sep 13 16:05:05 2024 -0300 [patch] Add cos prefix in use_hmac parameter (#1241) Co-authored-by: Alexandre Quinteiro <alequint@Alexandres-MBP.lan> Co-authored-by: Chirag Satani <ChiragSatani@ibm.com> Co-authored-by: Leonardo Miranda <Leo.Miranda@ibm.com> commit 71f07f6 Author: Andrew Whitfield <whitfiea@uk.ibm.com> Date: Thu Sep 12 15:22:42 2024 +0100 [patch] Check for no status on subscription - gitops (#1238) commit 35ea966 Author: Ian Boden <82514609+IanBoden@users.noreply.github.com> Date: Thu Sep 12 14:20:02 2024 +0100 [patch] Add support for mirroring odf dependcies that are required for 4.15 (#1235) commit 7ea23a9 Author: David Parker <parkerda@uk.ibm.com> Date: Wed Sep 11 09:39:48 2024 +0100 [doc] Fix "IBM License Key Center" link in docs commit 6c2b88b Author: David Parker <parkerda@uk.ibm.com> Date: Tue Sep 10 09:31:01 2024 +0100 [doc] Doc updates & latest CLI version update commit 8b6b7c6 Author: Vishal-patel-7 <142403240+Vishal-patel-7@users.noreply.github.com> Date: Tue Sep 10 08:53:27 2024 +0530 [minor] Added HMAC to COS role (#1228) Co-authored-by: unnati-solanki-git <131964221+unnati-solanki-git@users.noreply.github.com> commit b0035d3 Author: David Parker <parkerda@uk.ibm.com> Date: Mon Sep 9 12:28:08 2024 +0100 [doc] Minor doc updates commit b8989fc Author: David Parker <parkerda@uk.ibm.com> Date: Mon Sep 9 11:33:21 2024 +0100 [doc] Update examples commit dd6edf4 Author: David Parker <parkerda@uk.ibm.com> Date: Sun Sep 8 13:43:22 2024 +0100 [skip ci] Add EAM migration example commit 831e892 Author: Tremaine Hart <twhart@us.ibm.com> Date: Fri Sep 6 10:27:00 2024 -0500 [minor] [MASCORE-3026] implement role/tasks for new deployments of MongoDB CE v7.0 (#1232) commit 94b4f8d Author: unnati-solanki-git <131964221+unnati-solanki-git@users.noreply.github.com> Date: Fri Sep 6 18:10:00 2024 +0530 [patch] moving user timeout in the end (#1230) commit 10d7a2b Author: David Parker <parkerda@uk.ibm.com> Date: Thu Sep 5 14:44:17 2024 +0100 [doc] Update Documentation and support [doc] commit prefix commit 5268e7f Author: David Parker <parkerda@uk.ibm.com> Date: Thu Sep 5 11:47:36 2024 +0100 [major] Remove image mirroring support for UDS (#1231) commit 4bc95cf Author: Matheus Cardoso de Medeiros <38898699+RexMCM@users.noreply.github.com> Date: Thu Sep 5 06:29:44 2024 -0300 [patch] Add support for enabling special characters in ID/username field (#1176) Co-authored-by: Matheus Cardoso de Medeiros <Matheus.Cardoso@ibm.com> Co-authored-by: David Parker <parkerda@uk.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to support the junitreporter chart added in ibm-mas/gitops#201 that will allow all the gitops charts to report the sync start and end time. This allows the devopsdb to be populated with the details on where the deploy is via the devopdb. This intoruces a new productId of
ibm-mas-gitopswhilst keeping the default asibm-mas-devopsThe bootstrap config for ArgoCD has been updated to include
helm dependency update;in the AVP Plugin so that the new sub-chart can be processed. This config is needed even if the devops_mongo_uri is not being set.In order to do this a new junit-xml-generator.py script is added that allows an junit xml report to be created based on testcases passed in. This change also includes updates to the
gitops_clusterfunction to allow thedevops_mongo_urito be set and thedevops_build_numberLastly in order to allow a mustgather to be generated with the fvt-preparer fails (due to an argo app not being healthy) then changes have been made to allow
check_argo_app_healthyto timeout after a set number of retries. When that happens a mustgather will be produced and uploaded.As per ibm-mas/gitops#201 this has been tested in our test env