[patch] Fixes and updates for IBMCloud COS support #1347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twhart
requested review from
durera,
JonahLuckett,
andrercm,
sanjayprab,
terenceq,
whitfiea,
alequint and
leo-miran
as code owners
durera
changed the title
durera
requested changes
Nov 14, 2024
durera
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup COS so it doesn't rely on the ibmcloud_apikey if the cos_apikey has been set. This allows for a less privileged apikey to be used. Renamed some variables to align more closely to how the rest of COS is used
Tested here:
https://dashboard.masdev.wiotp.sl.hursley.ibm.com/tests/pfvtcos
See also: MASCORE-4345