Allow creating new Builders using BaseRecordBuilder #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current `BaseRecordBuilder` interface defines some abstract methods, without declaring their visibility. This means it is by default, they are `package-private`, and we can't create sub-classes extending the behaviour. One scenario where extanding from another package is ideal would be when extra headers are required to be sent to Kafka. This commit changes the modifier to be public so others could extend them.
|
This looks like a useful change. I'll take a look when I get some free time. |
AndrewJSchofield
suggested changes
Apr 14, 2019
|
I accept the CLA |
AndrewJSchofield
approved these changes
Apr 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
BaseRecordBuilderinterface defines some abstract methods,without declaring their visibility.
This means it is by default, they are
package-private, and we can'tcreate sub-classes extending the behaviour.
One scenario where extanding from another package is ideal would be when
extra headers are required to be sent to Kafka. This commit changes the
modifier to be public so others could extend them.