Acquire interruptLock for interruptImpl and isInterruptedImpl #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
interruptImpl and isInterruptedImpl use the eetop/threadRef value. Acquiring interruptLock assures that the eetop/threadRef value won't change during interruptImpl and isInterruptedImpl. This will prevent crashes which happen when a stale eetop/threadRef value is used to invoke OMR thread library functions. Related: eclipse-openj9/openj9#19544 Related: eclipse-openj9/openj9#19598 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
|
Started a personal build on |
|
Only infra and known failures are seen in the personal build. In a grinder for the |
|
jenkins test sanity zlinux jdknext |
|
@babsingh Please open backports |
babsingh
added a commit
to babsingh/openj9-openjdk-jdk21
that referenced
this pull request
Jun 18, 2024
interruptImpl and isInterruptedImpl use the eetop/threadRef value. Acquiring interruptLock assures that the eetop/threadRef value won't change during interruptImpl and isInterruptedImpl. This will prevent crashes which happen when a stale eetop/threadRef value is used to invoke OMR thread library functions. Related: eclipse-openj9/openj9#19544 Related: eclipse-openj9/openj9#19598 Backport of ibmruntimes/openj9-openjdk-jdk#803 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh
added a commit
to babsingh/openj9-openjdk-jdk22
that referenced
this pull request
Jun 18, 2024
interruptImpl and isInterruptedImpl use the eetop/threadRef value. Acquiring interruptLock assures that the eetop/threadRef value won't change during interruptImpl and isInterruptedImpl. This will prevent crashes which happen when a stale eetop/threadRef value is used to invoke OMR thread library functions. Related: eclipse-openj9/openj9#19544 Related: eclipse-openj9/openj9#19598 Backport of ibmruntimes/openj9-openjdk-jdk#803 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh
added a commit
to babsingh/openj9-openjdk-jdk21
that referenced
this pull request
Jun 18, 2024
interruptImpl and isInterruptedImpl use the eetop/threadRef value. Acquiring interruptLock assures that the eetop/threadRef value won't change during interruptImpl and isInterruptedImpl. This will prevent crashes which happen when a stale eetop/threadRef value is used to invoke OMR thread library functions. Related: eclipse-openj9/openj9#19544 Related: eclipse-openj9/openj9#19598 Backport of ibmruntimes/openj9-openjdk-jdk#803 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
interruptImplandisInterruptedImpluse theeetop/threadRefvalue.Acquiring
interruptLockassures that theeetop/threadRefvalue won'tchange during
interruptImplandisInterruptedImpl. This will preventcrashes which happen when a stale
eetop/threadRefvalue is used toinvoke OMR thread library functions.
Related: eclipse-openj9/openj9#19544
Related: eclipse-openj9/openj9#19598