This repository has been archived by the owner on Dec 13, 2024. It is now read-only.
LUDCL refresh points #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There exist different points where LUDCL is refreshed by a stackWalk where it's not needed, this commit removes these cases and stackWalking only when it needs to. Signed-off-by: Abdulrahman Alattas <rmnattas@gmail.com>
pshipton
approved these changes
Aug 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
ObjectInputStream, the latest user defined class loader (LUDCL) is cached. The cache is refreshed at different points in the code by walking the stack, some of the points are called more ofter than where the LUDCL is actually needed (inresolveClass()). This causes the cache to be refreshed and perform a stackWalk more times than LUDCL is used.This fix removes the points of refresh outside
resolveClass()so a stackWalk is performed at most as many times the LUDCL is needed, or less if already cached.eclipse-openj9/openj9#15570
Tests were run for the JDK11 PR: ibmruntimes/openj9-openjdk-jdk11#552 (comment)