Skip to content
This repository has been archived by the owner on Dec 13, 2024. It is now read-only.

[JEP424] Implement VaList on Power (Linux & AIX) in JDK19 #27

Merged
merged 1 commit into from
Oct 2, 2022
Merged

[JEP424] Implement VaList on Power (Linux & AIX) in JDK19 #27

merged 1 commit into from
Oct 2, 2022

Conversation

ChengJin01
Copy link

@ChengJin01 ChengJin01 commented Sep 8, 2022 •
edited
Loading

The changes aim to enable the VaList support on Power (Linux & AIX)
by implementing the VaList specific APIs in OpenJDK given the underlying
code has been offered in OpenJ9.

Note:
The PR is part of FFI downcall & upcall work at
eclipse-openj9/openj9#12412 and eclipse-openj9/openj9#15068.

Signed-off-by: Cheng Jin jincheng@ca.ibm.com

@ChengJin01
Copy link
Author

ChengJin01 commented Sep 8, 2022 •
edited
Loading

The changes have been verified with our VaList specific tests as well as the jtreg tests related to VaList at
https://github.com/ibmruntimes/openj9-openjdk-jdk19/blob/openj9/test/jdk/java/foreign/valist/VaListTest.java
and https://github.com/ibmruntimes/openj9-openjdk-jdk19/blob/openj9/test/jdk/java/foreign/TestVarArgs.java.

Note:
There is no code required in OpenJ9 given VaList is converted to pointer in native which has been handled in the existing code.

@ChengJin01
Copy link
Author

Reviewer: @tajila
FYI: @DanHeidinga, @pshipton, @gacholio

@ChengJin01 ChengJin01 force-pushed the jep424_implement_valist_power_jdk19 branch from c1f126d to 9161944 Compare September 8, 2022 03:49
This was referenced Sep 8, 2022
Merged
Closed
Merged
@ChengJin01 ChengJin01 force-pushed the jep424_implement_valist_power_jdk19 branch 2 times, most recently from 2dc832f to c69abe9 Compare September 13, 2022 18:16
@ChengJin01
Copy link
Author

ChengJin01 commented Sep 14, 2022 •
edited
Loading

The jtreg test VaListTest at https://github.com/ibmruntimes/openj9-openjdk-jdk19/blob/openj9/test/jdk/java/foreign/valist/VaListTest.java needs to updated accordingly on a given platform. I will need to double-check in case there is anything else I ignored previously.

@ChengJin01 ChengJin01 force-pushed the jep424_implement_valist_power_jdk19 branch from c69abe9 to 816541d Compare September 14, 2022 21:56
@ChengJin01
Copy link
Author

I've updated the jtreg test code at VaListTest for Power and resolved an issue with the boundary check on the memory region of VaList specific toskip() and nextVarg() in code which were detected in VaListTest. All VaList related tests have been verified with the latest code changes.

@ChengJin01 ChengJin01 force-pushed the jep424_implement_valist_power_jdk19 branch from 816541d to e04c883 Compare September 23, 2022 19:27
[JEP424] Implement VaList on Power in JDK19
aad123f 
The changes aim to enable the VaList support on Power
(Linux & AIX) by implementing the VaList specific APIs
in OpenJDK given the underlying code has been offered
in OpenJ9.

Note:
The PR is part of FFI downcall & upcall work at
eclipse-openj9/openj9#12412 and eclipse-openj9/openj9#15068.

Signed-off-by: Cheng Jin <jincheng@ca.ibm.com>
@ChengJin01 ChengJin01 force-pushed the jep424_implement_valist_power_jdk19 branch from e04c883 to aad123f Compare September 23, 2022 20:00
@tajila
Copy link
Member

tajila commented Sep 30, 2022

jenkins test sanity aix jdk19

@tajila tajila merged commit b9e3daf into ibmruntimes:openj9 Oct 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tajila tajila tajila approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChengJin01 @tajila