Skip to content
This repository has been archived by the owner on Dec 13, 2024. It is now read-only.

[JEP424]Implement VaList on zLinux in JDK19 #38

Merged

Conversation

ChengJin01
Copy link

@ChengJin01 ChengJin01 commented Oct 14, 2022

The changes aim to enable the VaList support on zLinux
by implementing the VaList specific APIs in OpenJDK
given the underlying code has been offered in OpenJ9.

Note:
The PR is part of FFI downcall & upcall work at
eclipse-openj9/openj9#12412 and eclipse-openj9/openj9#15068.

Signed-off-by: Cheng Jin jincheng@ca.ibm.com

@ChengJin01
Copy link
Author

The changes have been verified with our VaList specific tests as well as the jtreg tests related to VaList at
https://github.com/ibmruntimes/openj9-openjdk-jdk19/blob/openj9/test/jdk/java/foreign/valist/VaListTest.java
and https://github.com/ibmruntimes/openj9-openjdk-jdk19/blob/openj9/test/jdk/java/foreign/TestVarArgs.java.

Note:
There is no code required in OpenJ9 given VaList is converted to pointer in native which has been handled in the existing code.

@ChengJin01
Copy link
Author

Reviewer: @tajila
FYI: @DanHeidinga, @pshipton, @gacholio

@tajila
Copy link
Member

tajila commented Oct 17, 2022

@hangshao0 please review these changes

@hangshao0
Copy link
Contributor

@hangshao0 please review these changes

Sure.

@ChengJin01 ChengJin01 force-pushed the jep424_implement_valist_zlinux_jdk19 branch from be2f6fd to b0044e8 Compare October 17, 2022 21:43
The changes aim to enable the VaList support on zLinux
by implementing the VaList specific APIs in OpenJDK
given the underlying code has been offered in OpenJ9.

Note:
The PR is part of FFI downcall & upcall work at
eclipse-openj9/openj9#12412 and eclipse-openj9/openj9#15068.

Signed-off-by: Cheng Jin <jincheng@ca.ibm.com>
@ChengJin01 ChengJin01 force-pushed the jep424_implement_valist_zlinux_jdk19 branch from b0044e8 to bcc9af8 Compare October 17, 2022 22:17
Copy link
Contributor

@hangshao0 hangshao0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tajila
Copy link
Member

tajila commented Oct 21, 2022

jenkins test sanity zlinux jdk19

@tajila tajila merged commit 722a3c3 into ibmruntimes:openj9 Oct 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants