This repository has been archived by the owner on Dec 13, 2024. It is now read-only.
[Jtreg]Fix the issue with addVarg/nextVarg of VaList on Power #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR is to fix the VaList specific issue detected at https://github.com/ibmruntimes/openj9-openjdk-jdk19/blob/openj9/test/jdk/java/foreign/TestScopedOperations.java and also verified with other VaList related Jtreg test suites. |
ChengJin01
force-pushed
the
jep424_fix_valist_struct_jtreg_tests_jdk19
branch
from
110419b to
967daef
Compare
|
@hangshao0 Please review these changes |
|
I've already approved this change. @tajila I see you request me to review again, is that a miss-click ? |
|
My page was stale, thanks |
hangshao0
approved these changes
Oct 25, 2022
tajila
reviewed
Oct 25, 2022
src/java.base/share/classes/jdk/internal/foreign/abi/ppc64/aix/AixPPC64VaList.java
Outdated
Show resolved
Hide resolved
The change is to resolve the Jtreg test related issue with addVarg/nextVarg of VaList on Power to ensure the struct value is correctly read from va_list and added to va_list when the struct argument size is inconsistent with its layout size. Signed-off-by: Cheng Jin <jincheng@ca.ibm.com>
ChengJin01
force-pushed
the
jep424_fix_valist_struct_jtreg_tests_jdk19
branch
from
967daef to
72743a5
Compare
tajila
approved these changes
Oct 26, 2022
|
jenkins test sanity plinux jdk19 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change is to resolve the Jtreg test related issue with addVarg/nextVarg of VaList on Power to ensure the struct value is correctly read from va_list and added to va_list when the struct argument size is inconsistent with its layout size.
Signed-off-by: Cheng Jin jincheng@ca.ibm.com