This repository has been archived by the owner on Dec 13, 2024. It is now read-only.
Set interrupt field before native call #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a potential race if the interrupt field is set after the interrupt call where another thread may query interrupt status before the field is set. Fixes: eclipse-openj9/openj9#16174 Signed-off-by: Tobi Ajila <atobia@ca.ibm.com>
|
@JasonFengJ9 please review these changes |
|
jenkins test sanity zlinux jdk19 |
JasonFengJ9
approved these changes
Oct 28, 2022
There was a problem hiding this comment.
This restores the order of invoking interrupt0() after setting the field interrupted before #41
LGTM
|
@tajila please cherry-pick for JDK next. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set interrupt field before native call
There is a potential race if the interrupt field is set after the interrupt call where another thread may query interrupt status before the field is set.
Fixes: eclipse-openj9/openj9#16174
Signed-off-by: Tobi Ajila atobia@ca.ibm.com